Service fails to install if ~/Library/LaunchAgents doesn't exist

[aouerf]

This issue seems to be because the plist path is opened without checking if the directory exists:

yabai/src/misc/service.h

Lines 96 to 97 in f4ad453

	FILE *handle = fopen(yabai_plist_path, "w");
	if (!handle) return 1;

I believe the user experience here could be a bit better. I can make a PR for this when I get the chance, but I'm filing this issue in case someone can get to it before I do.

The same issue predictably exists for skhd.

[koekeishiya]

Fairly certain this folder will always exist unless a user has specifically decided to delete it, in which case I think failing is better than recreating it.

[aouerf]

It didn't exist after a fresh install of macOS, which is why I filed this issue since I had to dig in to figure out why it wasn't working since the error message wasn't very intuitive. I can definitely see where you're coming from though, so feel free to close this if you want to leave things as is.

[koekeishiya]

I assumed it would always be there (even after a fresh install) when reading Apple documentation, but as you pointed out that appears to not be the case.

I've changed the implementation on master to attempt to create the LaunchAgents folder if necessary before writing the file. Same change has been applied to skhd.

I am not going to push a new release just for this change though.

[plotchy]

Thanks for reporting this, I ran into this issue just now on a fresh install.

[vhagedorn]

Sorry for necro, but adding on to the solution:

If the directory did not exist, and the user had created it manually (as in my case), the permissions would not allow the process to write to the directory. This can be fixed with a simple chmod 775.

I encoutered this issue with skhd, but these appear to have the same impl, so I'm leaving my comment here.

Cheers
-vadim