Kitty is not always tiled

[ghost]

As you can see, Kitty is not always being tiled.

I have not been able to observe a pattern. If closing all the Kitty windows and then opening more, proper tiling resumes.

[goranmoomin]

@danteissaias Have you run yabai -m query --windows --space to analyze the problem?

[ghost]

This is the value of one of the non-tiled windows:

{
        "id":31133,
        "pid":50498,
        "app":"kitty",
        "title":"htop /Users/dante",
        "frame":{
                "x":692.0000,
                "y":287.0000,
                "w":100.0000,
                "h":100.0000
        },
        "level":0,
        "role":"AXWindow",
        "subrole":"AXStandardWindow",
        "movable":1,
        "resizable":1,
        "display":1,
        "space":1,
        "visible":1,
        "focused":0,
        "split":"none",
        "floating":1,
        "sticky":0,
        "border":1,
        "shadow":0,
        "zoom-parent":0,
        "zoom-fullscreen":0,
        "native-fullscreen":0
}

For some reason it seems to be floating, but I don't know why.

[goranmoomin]

@danteissaias I'm not sure why that happens (maybe a config messed it up? or it's a bug?) but you can use the signal system to manually make the floating values to 0 :-)
I haven't touched the signal system for a while, but there are events that are triggered when new windows are created.

[ghost]

@pcr910303 This issue occurs with the example configuration, could this issue possible be a relative of #174, since maybe the Kitty windows are not always defloated?

[ghost]

If its any help I discovered the trigger of this issue. If you open 4 Kitty windows tiled as so:

If you then create another Kitty window, and close it using CMD+W, the next Kitty window that is opened will suffer from this issue.

Until closing the suffering window, and the last window created before that:

All Kitty window subsequently created will not be tiled.

If you repeat these same steps, you can reproduce this issue on any application. I have tested this issue on Firefox Developer Edition and I can successfully reproduce it.

[koekeishiya]

Unable to reproduce using your steps. This may be a duplicate of #183 (?) which has been fixed on master.

In any case, can you reproduce this issue on the latest stable version (v1.1.2)?

[ghost]

It's not a duplicate of #183 as I am still able to produce this on master.

[ghost]

Here is a more detailed instruction on how to reproduce this issue, in case there was any confusion.

Edit: Here is a recording including keystrokes.

[koekeishiya]

I still can't reproduce this issue doing the exact steps shown in that video.

[koekeishiya]

So this is actually happening because there is a check for minimum window size upon creation, and if the window is smaller than the given dimensions, it will float instead: https://github.com/koekeishiya/yabai/blob/master/src/window.c#L263

I'm a bit reluctant to calling this a bug, but this is a sideeffect I had not considered..

[koekeishiya]

I think this should be considered a bug. We should only float small windows that are NOT resizable.