Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not managing wezterm-gui until after restarting yabai #2190

Closed
khaneliman opened this issue Mar 27, 2024 · 17 comments
Closed

Not managing wezterm-gui until after restarting yabai #2190

khaneliman opened this issue Mar 27, 2024 · 17 comments
Labels
bug Something isn't working

Comments

@khaneliman
Copy link

khaneliman commented Mar 27, 2024

After 7.0 (I think) I started noticing wezterm-gui from nixpkgs doesn't get managed until I restart yabai. If i launch wezterm while yabai is running it gets ignored from being tiled, for some reason.

EDIT: Played around with launching the .App instead of directly invoking the binary. When I launch the .App it is managed, i can then invoke the binary and see it managed if the .App is still running. But, launching the wezterm-gui binary itself seems to be ignored.

before: Screenshot 2024-03-27 at 3 51 18 PM
after: Screenshot 2024-03-27 at 3 51 43 PM
@koekeishiya
Copy link
Owner

Sounds like same issue as #2168

koekeishiya added a commit that referenced this issue Mar 28, 2024
@koekeishiya koekeishiya added the addressed on master; not released Fixed upstream, but not yet released label Mar 28, 2024
@koekeishiya
Copy link
Owner

Whitelisted on master.

@koekeishiya
Copy link
Owner

Changed how this works. Explicit whitelisting should no longer be necessary.

@koekeishiya koekeishiya added bug Something isn't working and removed addressed on master; not released Fixed upstream, but not yet released labels Mar 30, 2024
@koekeishiya
Copy link
Owner

Should be fixed in v7.0.4.

@khaneliman
Copy link
Author

Thanks, just updated to 7.0.4 and it works again. Appreciate it, @koekeishiya

@GameFuzzy
Copy link

GameFuzzy commented Apr 14, 2024

I'm still experiencing this issue running the latest commit (it's been like this since 82727a2), both with zathura and wezterm-gui, though it only seems to occur about 50% of the time.

@rcorre
Copy link

rcorre commented May 24, 2024

Same, I'm on yabai-v7.1.1, and wezterm is sometimes managed, sometimes not.

@GameFuzzy
Copy link

@koekeishiya could you please reopen this issue?

@3bbbeau
Copy link

3bbbeau commented Jul 18, 2024

It's not a permanent solution perhaps, but I realized this happened on both yabai and komorebi when I disabled the title bar in WezTerm during the initial configuration (which most people do with tiling WMs).

I made a compromise by setting:

config.window_decorations = "INTEGRATED_BUTTONS|RESIZE"

I tried it with both Windows and macOS which resolved the problem for me, and it still looks nice for me with tabs. So perhaps something to do with Wezterm and how disabling the title bar exposes the handle within the OS API.

@GameFuzzy
Copy link

It's not a permanent solution perhaps, but I realized this happened on both yabai and komorebi when I disabled the title bar in WezTerm during the initial configuration (which most people do with tiling WMs).

I made a compromise by setting:

config.window_decorations = "INTEGRATED_BUTTONS|RESIZE"

I tried it with both Windows and macOS which resolved the problem for me, and it still looks nice for me with tabs. So perhaps something to do with Wezterm and how disabling the title bar exposes the handle within the OS API.

Didn't fix the issue on my end.

@escwxyz
Copy link

escwxyz commented Aug 20, 2024

Issue persists with yabai v7.1.2

Resolved after script injection.

@AlJohri
Copy link

AlJohri commented Sep 1, 2024

I'm also running into the same issue. I just reported it upstream to wezterm here: wez/wezterm#6075

@escwxyz
Copy link

escwxyz commented Sep 1, 2024

I'm also running into the same issue. I just reported it upstream to wezterm here: wez/wezterm#6075

Make sure to re-run the script injection.

That's how I solved the issue.

@AlJohri
Copy link

AlJohri commented Sep 1, 2024

Make sure to re-run the script injection.

@escwxyz Are you suggesting to re-run sudo yabai --load-sa? That didn't work for me. However, yabai --restart-service did indeed fix it although that's not a long term solution.

Screen.Recording.2024-09-01.at.11.22.06.AM.mov

@AlJohri
Copy link

AlJohri commented Sep 1, 2024

I made a compromise by setting:

config.window_decorations = "INTEGRATED_BUTTONS|RESIZE"

FWIW, this also did not work for me.

Note, the issue only occurs for me when I run wezterm via the CLI.

@AlJohri
Copy link

AlJohri commented Sep 1, 2024

Found a workaround! Following the advice here for alacritty, If I run wezterm via the CLI like this it seems to work properly:

/Applications/WezTerm.app/Contents/MacOS/wezterm

@Avishayy
Copy link

Avishayy commented Sep 5, 2024

For what it's worth, I'm having the same issue, and unless window_decorations are set to at least INTEGRATED_BUTTONS, the window is unmanaged, I don't like having the integrated buttons on my terminal windows, so for now I'm just using fullscreen, but this does seem like an issue with yabai where it doesn't manage windows without decorations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

8 participants