-
-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Un-hiding chrome causes resize issue. #300
Comments
I'm seeing this too. Switching spaces back and forth also fixes the issue. My guess is that Chrome is making some kind of "false" window that yabai is picking up on, it's destroying that window in some way yabai doesn't notice, and then it has to be nudged to recalculate everything. I know Chrome's little URL preview is a "window" for some definition, because Zoom offers to screen share it during meetings. Could that be what's doing it? |
Likely related: #164 (don't think these are properly ignored for unhiding) |
Role is also checked upon unhiding. Simply having Kitty open. Launching Chrome, navigate to some website, hide Chrome, unhide Chrome, is not enough to reproduce the issue for me. Tested both while having the url-window visible and without it. Need more information somehow before I can try to pinpoint what is happening here. |
Any recommendations for ways to log the necessary info?
On Wed, Nov 6, 2019 at 6:03 AM Åsmund Vikane ***@***.***> wrote:
Role is also checked upon unhiding. Simply having Kitty open. Launching
Chrome, navigate to some website, hide Chrome, unhide Chrome, is not enough
to reproduce the issue for me. Tested both while having the url-window
visible and without it. Need more information somehow before I can try to
pinpoint what is happening here.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#300?email_source=notifications&email_token=AB7QUTB7HKOFP35AOR6CXW3QSLFBJA5CNFSM4JIOZE7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDGUDNY#issuecomment-550322615>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB7QUTEEIAQDSSBWOVA5SYLQSLFBJANCNFSM4JIOZE7A>
.
--
-- Alok
|
My first thought would be to add the ability to inspect/dump the underlaying tree structure to file. It would be trivial to also dump information about the window that belongs to each leaf node. Having an output like that would make it fairly trivial to identify what the problem is. The next step would then be to try and figure out how that scenario was able to occur in the first place. I guess this could be something like |
I'm able to get yabai to recompute correctly by entering Expose, or even just barely starting to enter Expose with the trackpad, and going back. Is there something I could do from the command line that might accomplish the same thing? If so, a workaround for now might be to attach that command to an |
This should be fixed after the changes made for #348 |
Hooray! Thank you! |
Hmm, I'm still seeing this. :/
I've restarted yabai and reinstalled the payload, so it should be running the right code. Is there anything else I can do to help debug? |
I really don't get why i don't have this problem??? Anyway, someone will have to investigate this by actually running a debug build of yabai in a debugger and stepping through the code to figure out what is going on. You can start by setting a breakpoint at: https://github.com/koekeishiya/yabai/blob/master/src/event.c#L425 to see the value of |
The only reason I can think of would be if there is a minimized window, and then the application is unhidden? |
…ed by some applications like Chrome..)
Theory regarding minimized window turned out to be correct. Usually the API does not return minimized windows through the AX API in this scenario, but apparently Chrome does for some reason... |
Aha! Can confirm: if I have no Chrome windows minimized, this doesn't happen. If I have two windows minimized, I can prove they're both accounted in the empty space for by running |
…den (required by some applications like Chrome..)
I have the screen split (vertically) evenly between chrome and kitty.
I hide chrome with cmd+h. Kitty is now the only app in view.
I then unhide chrome. Kitty resizes to half the screen, but chrome only resizes to a fourth, leaving a quarter of the screen unused.
If I use the native fullscreen on chrome and switch back, it fixes the issue, but I have to do that every time I hide chrome.
The text was updated successfully, but these errors were encountered: