Blank space appears when restoring minimised window #70

eramdam · 2019-06-25T17:39:10Z

I can't exactly pinpoint (yet) a specific pattern but I've seen that happen quite a few times on my work machine, I would restore a window that was minimized and then there would be a blank space in the tiling, as if there was a "ghost" window there 😕

I'll try to gather some logs around the time when it happens to see if there's any errors popping up.

FWIW I'm on a dual monitor setup (built-in display + 4K monitor) on a 2015 MBP and it happened ~5times yesterday but I have never seen that on my desktop computer with a similar monitor setup so i don't know if it's a performance issue?

EDIT:
Okay here are some query results on a space where that happened. I'm remembering that my secondary display is on the left of the main one, making it having a negative x value, maybe that's relevant for the issue? (My desktop computer has its secondary display on the right so the x is probably positive)

yabai -m query --displays --space
{
	"id":69733248,
	"index":2,
	"spaces":4,
	"frame":{
		"x":-1920.0000,
		"y":495.0000,
		"w":1920.0000,
		"h":1200.0000
	}
}

» yabai -m query --spaces --space
{
	"id":6,
	"index":4,
	"display":2,
	"windows":2,
	"type":"bsp"
}

» yabai -m query --windows --space
[{
	"id":2963,
	"pid":22607,
	"app":"iTerm2",
	"title":"/usr/local/var/log/yabai",
	"frame":{
		"x":-1898.0000,
		"y":1118.0000,
		"w":1161.0000,
		"h":552.0000
	},
	"level":"0",
	"role":"AXWindow",
	"subrole":"AXStandardWindow",
	"movable":1,
	"resizable":1,
	"native-fullscreen":0,
	"floating":0
},{
	"id":479,
	"pid":6809,
	"app":"Front",
	"title":"Front",
	"frame":{
		"x":-1898.0000,
		"y":539.0000,
		"w":1165.0000,
		"h":700.0000
	},
	"level":"0",
	"role":"AXWindow",
	"subrole":"AXStandardWindow",
	"movable":1,
	"resizable":1,
	"native-fullscreen":0,
	"floating":0
}]

» yabai -m query --displays
[{
	"id":722476558,
	"index":1,
	"spaces":1,
	"frame":{
		"x":0.0000,
		"y":0.0000,
		"w":3840.0000,
		"h":2160.0000
	}
},{
	"id":69733248,
	"index":2,
	"spaces":4,
	"frame":{
		"x":-1920.0000,
		"y":495.0000,
		"w":1920.0000,
		"h":1200.0000
	}
}]

The text was updated successfully, but these errors were encountered:

dominiklohmann · 2019-06-25T18:05:28Z

Can you run yabai --verbose (need to stop the launch agent first) and show the output around the time this happens?

eramdam · 2019-06-25T19:34:21Z

I'll try that, in the mean-time I noticed I can repro consistenyl by opening a new Finder tab

EVENT_HANDLER_MOUSE_DOWN: 1457.49, 1716.91
EVENT_HANDLER_MOUSE_UP: 1457.49, 1716.91
EVENT_HANDLER_APPLICATION_FRONT_SWITCHED: Finder
EVENT_HANDLER_APPLICATION_DEACTIVATED: iTerm2
EVENT_HANDLER_APPLICATION_ACTIVATED: Finder
EVENT_HANDLER_WINDOW_CREATED: Finder 8016
EVENT_HANDLER_WINDOW_RESIZED: Finder 7894
EVENT_HANDLER_WINDOW_MOVED: Finder 8016
EVENT_HANDLER_WINDOW_RESIZED: Finder 8016
EVENT_HANDLER_WINDOW_FOCUSED: Finder 8016
EVENT_HANDLER_MOUSE_DOWN: 833.43, 939.75
EVENT_HANDLER_APPLICATION_FRONT_SWITCHED: iTerm2
EVENT_HANDLER_APPLICATION_DEACTIVATED: Finder
EVENT_HANDLER_APPLICATION_ACTIVATED: iTerm2
EVENT_HANDLER_MOUSE_UP: 833.43, 939.75
EVENT_HANDLER_MOUSE_DOWN: 176.46, 0.00
EVENT_HANDLER_MOUSE_UP: 176.46, 0.00
EVENT_HANDLER_MOUSE_DOWN: 591.72, 396.96
EVENT_HANDLER_MOUSE_UP: 592.27, 396.96
EVENT_HANDLER_MOUSE_DOWN: 34.31, 1033.27
EVENT_HANDLER_MOUSE_UP: 458.51, 1009.47
EVENT_HANDLER_MOUSE_DOWN: 418.52, 1018.75
EVENT_HANDLER_MOUSE_UP: 48.66, 636.89
EVENT_HANDLER_MOUSE_DOWN: 27.55, 632.83
EVENT_HANDLER_MOUSE_UP: 530.37, 1096.78

dominiklohmann · 2019-06-25T19:35:13Z

See #68 for the tabs issue. This has a long history.

eramdam · 2019-06-25T19:36:31Z

Hum, I don't remember chunkwm having the same issue, but maybe it's because I wasn't using tabs as much. I just thought it'd be somewhat related to the issue I mentioned at first. I'll run yabai with verbose mode for the rest of the day to see if I can catch anything.

eramdam · 2019-06-25T19:48:02Z

Ok it just happened, here are the logs:

yabai --verbose around when it happened

EVENT_HANDLER_WINDOW_FOCUSED: Finder 8295
EVENT_HANDLER_MOUSE_DOWN: 543.35, 794.93
EVENT_HANDLER_APPLICATION_FRONT_SWITCHED: iTerm2
EVENT_HANDLER_APPLICATION_DEACTIVATED: Finder
EVENT_HANDLER_APPLICATION_ACTIVATED: iTerm2
EVENT_HANDLER_MOUSE_UP: 543.35, 794.93
EVENT_HANDLER_WINDOW_TITLE_CHANGED: iTerm2 7845
EVENT_HANDLER_MOUSE_DOWN: 2262.45, 2146.20
EVENT_HANDLER_MOUSE_UP: 2262.45, 2146.20
EVENT_HANDLER_APPLICATION_FRONT_SWITCHED: Code
EVENT_HANDLER_APPLICATION_DEACTIVATED: iTerm2
EVENT_HANDLER_APPLICATION_ACTIVATED: Code
EVENT_HANDLER_WINDOW_DEMINIMIZED: window Code 3752 is deminimized on active space
EVENT_HANDLER_WINDOW_TITLE_CHANGED: iTerm2 7845
EVENT_HANDLER_WINDOW_RESIZED: iTerm2 7845
EVENT_HANDLER_WINDOW_MOVED: Code 3752
EVENT_HANDLER_WINDOW_RESIZED: Code 3752
EVENT_HANDLER_WINDOW_FOCUSED: Code 3752
EVENT_HANDLER_WINDOW_MOVED: Code 3752
EVENT_HANDLER_WINDOW_RESIZED: Code 3752
EVENT_HANDLER_WINDOW_TITLE_CHANGED: iTerm2 7845
EVENT_HANDLER_MOUSE_DOWN: 735.49, 641.95
EVENT_HANDLER_APPLICATION_FRONT_SWITCHED: iTerm2
EVENT_HANDLER_APPLICATION_DEACTIVATED: Code
EVENT_HANDLER_APPLICATION_ACTIVATED: iTerm2
EVENT_HANDLER_MOUSE_UP: 735.49, 641.95
EVENT_HANDLER_WINDOW_TITLE_CHANGED: iTerm2 7845
EVENT_HANDLER_MOUSE_DOWN: 1245.98, 797.17
EVENT_HANDLER_MOUSE_UP: 1245.98, 797.17
EVENT_HANDLER_APPLICATION_FRONT_SWITCHED: Finder
EVENT_HANDLER_APPLICATION_DEACTIVATED: iTerm2
EVENT_HANDLER_APPLICATION_ACTIVATED: Finder
EVENT_HANDLER_MOUSE_DOWN: 2055.72, 1347.48
EVENT_HANDLER_APPLICATION_FRONT_SWITCHED: Code
EVENT_HANDLER_APPLICATION_DEACTIVATED: Finder
EVENT_HANDLER_APPLICATION_ACTIVATED: Code
EVENT_HANDLER_MOUSE_UP: 2055.72, 1347.48
EVENT_HANDLER_MOUSE_DOWN: 1969.84, 1089.85
EVENT_HANDLER_MOUSE_UP: 1969.84, 1089.85
EVENT_HANDLER_WINDOW_MINIMIZED: Code 3752
EVENT_HANDLER_WINDOW_TITLE_CHANGED: iTerm2 7845
EVENT_HANDLER_WINDOW_RESIZED: iTerm2 7845
EVENT_HANDLER_MOUSE_DOWN: 2089.87, 1519.85
EVENT_HANDLER_MOUSE_UP: 2089.87, 1519.85
EVENT_HANDLER_APPLICATION_FRONT_SWITCHED: Finder
EVENT_HANDLER_APPLICATION_DEACTIVATED: Code
EVENT_HANDLER_APPLICATION_ACTIVATED: Finder
EVENT_HANDLER_MOUSE_DOWN: 1523.00, 1665.59
EVENT_HANDLER_MOUSE_UP: 1520.71, 1667.23
EVENT_HANDLER_WINDOW_FOCUSED: Finder 8295
EVENT_HANDLER_WINDOW_TITLE_CHANGED: iTerm2 7845
EVENT_HANDLER_MOUSE_DOWN: 2143.88, 721.84
EVENT_HANDLER_APPLICATION_FRONT_SWITCHED: Firefox
EVENT_HANDLER_APPLICATION_DEACTIVATED: Finder
EVENT_HANDLER_APPLICATION_ACTIVATED: Firefox
EVENT_HANDLER_MOUSE_UP: 2143.88, 721.84
EVENT_HANDLER_MOUSE_DOWN: 449.06, 691.57
EVENT_HANDLER_APPLICATION_FRONT_SWITCHED: iTerm2
EVENT_HANDLER_APPLICATION_DEACTIVATED: Firefox
EVENT_HANDLER_APPLICATION_ACTIVATED: iTerm2
EVENT_HANDLER_MOUSE_UP: 449.06, 691.57
EVENT_HANDLER_WINDOW_TITLE_CHANGED: iTerm2 7845
process_handler: osascript was marked as background only! ignoring..
EVENT_HANDLER_MOUSE_DOWN: 33.94, 597.62

query before I relaunched yabai to fix the issue

» yabai -m query --windows --space
[{
	"id":7845,
	"pid":22607,
	"app":"iTerm2",
	"title":"~/Music/XLD",
	"frame":{
		"x":22.0000,
		"y":44.0000,
		"w":929.0000,
		"h":1000.0000
	},
	"level":"0",
	"role":"AXWindow",
	"subrole":"AXStandardWindow",
	"movable":1,
	"resizable":1,
	"native-fullscreen":0,
	"floating":0
},{
	"id":4057,
	"pid":21286,
	"app":"Firefox",
	"title":"[5] Blank space appears when restoring minimised window · Issue #70 · koekeishiya/yabai",
	"frame":{
		"x":1932.0000,
		"y":44.0000,
		"w":1886.0000,
		"h":1013.0000
	},
	"level":"0",
	"role":"AXWindow",
	"subrole":"AXStandardWindow",
	"movable":1,
	"resizable":1,
	"native-fullscreen":0,
	"floating":0
},{
	"id":3752,
	"pid":26647,
	"app":"Code",
	"frame":{
		"x":1932.0000,
		"y":1081.0000,
		"w":1886.0000,
		"h":1012.0000
	},
	"level":"0",
	"role":"AXWindow",
	"subrole":"AXStandardWindow",
	"movable":1,
	"resizable":1,
	"native-fullscreen":0,
	"floating":0
},{
	"id":8295,
	"pid":740,
	"app":"Finder",
	"title":"/Users/damien/Music/XLD/Depeche Mode_R1-587589",
	"frame":{
		"x":22.0000,
		"y":1081.0000,
		"w":1886.0000,
		"h":1012.0000
	},
	"level":"0",
	"role":"AXWindow",
	"subrole":"AXStandardWindow",
	"movable":1,
	"resizable":1,
	"native-fullscreen":0,
	"floating":0
}]

query after relaunching yabai

» yabai -m query --windows --space
[{
	"id":7845,
	"pid":22607,
	"app":"iTerm2",
	"title":"~/Music/XLD",
	"frame":{
		"x":22.0000,
		"y":44.0000,
		"w":930.0000,
		"h":1000.0000
	},
	"level":"0",
	"role":"AXWindow",
	"subrole":"AXStandardWindow",
	"movable":1,
	"resizable":1,
	"native-fullscreen":0,
	"floating":0
},{
	"id":8295,
	"pid":740,
	"app":"Finder",
	"title":"/Users/damien/Music/XLD/Depeche Mode_R1-587589",
	"frame":{
		"x":977.0000,
		"y":44.0000,
		"w":931.0000,
		"h":1012.0000
	},
	"level":"0",
	"role":"AXWindow",
	"subrole":"AXStandardWindow",
	"movable":1,
	"resizable":1,
	"native-fullscreen":0,
	"floating":0
},{
	"id":4057,
	"pid":21286,
	"app":"Firefox",
	"title":"[5] Blank space appears when restoring minimised window · Issue #70 · koekeishiya/yabai",
	"frame":{
		"x":1932.0000,
		"y":44.0000,
		"w":1886.0000,
		"h":2049.0000
	},
	"level":"0",
	"role":"AXWindow",
	"subrole":"AXStandardWindow",
	"movable":1,
	"resizable":1,
	"native-fullscreen":0,
	"floating":0
},{
	"id":3752,
	"pid":26647,
	"app":"Code",
	"title":"viewerPanelActions.ts — front-client",
	"frame":{
		"x":22.0000,
		"y":1081.0000,
		"w":1886.0000,
		"h":1012.0000
	},
	"level":"0",
	"role":"AXWindow",
	"subrole":"AXStandardWindow",
	"movable":1,
	"resizable":1,
	"native-fullscreen":0,
	"floating":0
}]

…zed on inactive display

koekeishiya · 2019-06-25T21:21:31Z

Fixed on master.

When a window is deminimized, macOS will automtically give focus to the space that window belongs to. In a multi-display setup, this would trigger a display changed event, and a window deminimized event for that window. The window would be added twice to the window-tree, once because we detect unmanaged windows upon space activation, and a second time because of the deminimized event.

koekeishiya added a commit that referenced this issue Jun 25, 2019

#70 window should not be added twice to the window-tree when deminimi…

d732ee7

…zed on inactive display

koekeishiya added addressed on master; not released Fixed upstream, but not yet released bug Something isn't working labels Jun 25, 2019

koekeishiya closed this as completed Jun 25, 2019

koekeishiya removed the addressed on master; not released Fixed upstream, but not yet released label Jun 25, 2019

peppy mentioned this issue Dec 19, 2019

Ghost window occasioanlly appear, causing incorrect layout #348

Closed

JDKardia pushed a commit to JDKardia/yabai that referenced this issue Apr 7, 2023

koekeishiya#70 fix memory leak, and code cleanup

3aac693

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Blank space appears when restoring minimised window #70

Blank space appears when restoring minimised window #70

eramdam commented Jun 25, 2019 •

edited

Loading

dominiklohmann commented Jun 25, 2019

eramdam commented Jun 25, 2019 •

edited

Loading

dominiklohmann commented Jun 25, 2019

eramdam commented Jun 25, 2019 •

edited

Loading

eramdam commented Jun 25, 2019 •

edited

Loading

koekeishiya commented Jun 25, 2019 •

edited

Loading

Blank space appears when restoring minimised window #70

Blank space appears when restoring minimised window #70

Comments

eramdam commented Jun 25, 2019 • edited Loading

dominiklohmann commented Jun 25, 2019

eramdam commented Jun 25, 2019 • edited Loading

dominiklohmann commented Jun 25, 2019

eramdam commented Jun 25, 2019 • edited Loading

eramdam commented Jun 25, 2019 • edited Loading

koekeishiya commented Jun 25, 2019 • edited Loading

eramdam commented Jun 25, 2019 •

edited

Loading

eramdam commented Jun 25, 2019 •

edited

Loading

eramdam commented Jun 25, 2019 •

edited

Loading

eramdam commented Jun 25, 2019 •

edited

Loading

koekeishiya commented Jun 25, 2019 •

edited

Loading