-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplicate ipex initialization code #1060
Conversation
fix vram usage in LoRA training
|
Thanks for the comments!
Fair, I can change those back – you could consider packaging your library as an actual Python package, though. If you need a hand with that, please let me know.
It shouldn't have any technical difference. All this PR does is move the same code into a function and call it.
I don't think so. The exact same exception handling is in the new initialization function, although in a slightly different form. Anyway, I'll change this a little more to avoid touching |
b1241f2
to
e6d4ded
Compare
Other than the logging i mentioned, this pr is good to merge. |
e6d4ded
to
6f3f701
Compare
Thank you for this PR and reviewing! |
Fix backwards condition here
This PR moves the repeated IPEX/XPU initialization code to a single place in
library/ipex_interop.py
.cc @Disty0