Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize lora add new rank for conv #1102

Merged
merged 3 commits into from
Feb 24, 2024

Conversation

mgz-dev
Copy link
Contributor

@mgz-dev mgz-dev commented Feb 4, 2024

Actual code changes are minor.

  • Fixed the formatting for indentions to be consistent with the rest of the files in repo.
  • Updated the script to match the other lora scripts and take in --new_conv_rank as an argument.
  • Updated the load and save functions to be more similar to other script as well.

update script to also take a separate conv rank value
@kohya-ss
Copy link
Owner

kohya-ss commented Feb 7, 2024

Thank you! This is very nice! I will merge this sooner when I have time.

@kohya-ss kohya-ss merged commit 738c397 into kohya-ss:dev Feb 24, 2024
1 check passed
@kohya-ss
Copy link
Owner

Thank you again, and sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants