Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download WD tagger models using HF's snapshot_download() #1162

Closed
wants to merge 3 commits into from

Conversation

liesened
Copy link

@liesened liesened commented Mar 7, 2024

The issue is that newer WD tagger models were released and they don't follow the usual TF repo structure, while their ONNX versions can be used as a drop-in replacements:
https://huggingface.co/SmilingWolf/wd-convnext-tagger-v3
https://huggingface.co/SmilingWolf/wd-vit-tagger-v3
https://huggingface.co/SmilingWolf/wd-swinv2-tagger-v3

This PR replaces old hf_hub_download code with snapshot_download() to allow downloading the entire repo instead of chosen files.

This change quickly allows downloading and running the newest WD tagger ONNX models while (hopefully) not breaking compatibility with the old code and models. Since these new models don't rely on tensorflow, and only ONNX version runs without any modifications, I would like to ask you how would you prefer to deal with it.

@kohya-ss kohya-ss mentioned this pull request Mar 14, 2024
@liesened
Copy link
Author

Closing in favor of #1192

@liesened liesened closed this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant