Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I want to propose small changes for loading
args.sample_prompt
. I added.toml
support so we can easily assign the sample prompt parameter to each key instead of putting all parameters in one line (using.txt
). The sample prompt parameter is also more readable and easy to maintain. Not only that, we don't need to set the same parameter again because I borrowed thedataset_config
approach by using[[prompt.subset]]
to store additional parameters.An example of
sample_prompt.toml
is as follows:We can also set prompt into different resolution or using a different sampler for each prompt by putting important parameters to
[[prompt.subset]].
Example:
I also added
.json
support in the latest commit.Thank you