[Fix rubocop#106] Fix an errof for Minitest/AssertOutput cop

Fixes rubocop#106. This PR fixes an error for `Minitest/AssertOutput` when using gvar at top level.
koic · Jul 17, 2020 · 953a5b9 · 953a5b9
1 parent ab80c8b
commit 953a5b9
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## master (unreleased)
 
+### Bug fixes
+
+* [#106](https://github.com/rubocop-hq/rubocop-minitest/issues/106): Fix an error for `Minitest/AssertOutput` when using gvar at top level. ([@koic][])
+
 ## 0.10.0 (2020-07-12)
 
 ### New features

diff --git a/lib/rubocop/cop/mixin/minitest_exploration_helpers.rb b/lib/rubocop/cop/mixin/minitest_exploration_helpers.rb
@@ -26,7 +26,7 @@ def test_class?(class_node)
       end
 
       def test_case?(node)
-        return false unless node.def_type? && test_case_name?(node.method_name)
+        return false unless node&.def_type? && test_case_name?(node.method_name)
 
         class_ancestor = node.each_ancestor(:class).first
         test_class?(class_ancestor)

diff --git a/test/rubocop/cop/minitest/assert_output_test.rb b/test/rubocop/cop/minitest/assert_output_test.rb
@@ -47,4 +47,10 @@ def test_do_something
       end
     RUBY
   end
+
+  def test_does_not_register_offense_when_using_gvar_at_top_level
+    assert_no_offenses(<<~RUBY)
+      $foo = false
+    RUBY
+  end
 end