Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow async-2.2 #25

Merged
merged 2 commits into from
Apr 8, 2018
Merged

Allow async-2.2 #25

merged 2 commits into from
Apr 8, 2018

Conversation

ndmitchell
Copy link
Contributor

Enables the inclusion back on stackage, which is required to get fsnotify and ghcid back on Stackage.

@ndmitchell
Copy link
Contributor Author

I note that the final test is failing, and that seems to be a test that something remains broken, so perhaps that's a good thing and hinotify is now fixed?

@jchia
Copy link
Contributor

jchia commented Mar 22, 2018

The async changelog mentioned a change in cancel behavior. I have a commit that addresses that, though being unfamiliar with hinotify I'm not really sure whether my additional async-2.2.1-specific exception treatment is needed.

@simonmichael simonmichael mentioned this pull request Mar 25, 2018
Closed
@simonmichael
Copy link

Ping. Could this be released/revised, so that hledger-ui can get back into stackage nightly.

@kolmodin kolmodin merged commit adfd4e1 into kolmodin:master Apr 8, 2018
@simonmichael
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ndmitchell @jchia @simonmichael @kolmodin