Fix panic when some objects cannot have specialized mesh pipelines. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was trying to use this crate together with [this crate](https://github.com/mattatz/bevy_points) and found this line panicking. There may be times where a user adds objects that cannot produce speciallized pipelines (for instance in this case, the crate does not populate normals). It seems to me there is no need to panic in these cases and just move on.
arjo129
changed the title
|
Thanks. Incorporated into #23. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to use this crate together with this crate and found
bevy_mod_outlinepanicking. There may be times where a user adds objects that cannot produce speciallized pipelines (for instance in this case, the crate does not populate normals). It seems to me there is no need to panic in these cases and just move on. In the worst case we probably should log a warning of some form.