Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc Features: Application shutdown #347

Merged
merged 3 commits into from
Apr 27, 2023
Merged

Doc Features: Application shutdown #347

merged 3 commits into from
Apr 27, 2023

Conversation

pushker001
Copy link
Contributor

@pushker001 pushker001 commented Apr 25, 2023

Begin documenting application features with describing application shutdown.

@pushker001 pushker001 changed the title Docs: To know to capability of application Docs: To know the capability of application Apr 25, 2023
@undera
Copy link
Collaborator

undera commented Apr 26, 2023

Please save the screenshot into images directory and reference it from doc, instead of third-party location.

Also, care about readers and make sure your English is more or less correct. Use ChatGPT for help, if needed:
Selection_001

@undera undera changed the title Docs: To know the capability of application Doc Features: Application shutdown Apr 26, 2023
@undera
Copy link
Collaborator

undera commented Apr 26, 2023

Note how I changed the title and description of PR to match the meaning of the changes more precisely.

Also, about the screenshot: avoid too much drawing on it. Simple arrow is enough to point to object. Sometimes when you want to outline large block, use simple rectangle, not circle. Small objects don't need rectangles at all.

Overall, this PR goes into right direction now. Thank you!

Please address my comments above to finalize it.

@undera
Copy link
Collaborator

undera commented Apr 27, 2023

Thanks for the contribution! It's a good first step to document the application features.

@undera undera merged commit 30eb209 into komodorio:main Apr 27, 2023
@pushker001 pushker001 deleted the DOcs branch April 27, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants