Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native targets #14

Merged
merged 4 commits into from
May 17, 2023
Merged

Add native targets #14

merged 4 commits into from
May 17, 2023

Conversation

luca992
Copy link
Contributor

@luca992 luca992 commented Apr 21, 2022

I added all native targets that kassert supports which are:

    "linuxX64",
    "macosX64", "macosArm64",
    "iosArm32", "iosArm64", "iosX64", "iosSimulatorArm64",
    "tvosArm64", "tvosX64", "tvosSimulatorArm64",
    "watchosArm32", "watchosArm64", "watchosX86", "watchosX64", 
    "watchosSimulatorArm64",

luca992 added a commit to luca992/KHash that referenced this pull request Apr 21, 2022
Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and sorry for the very late review. But the build fails for me with:


Some Kotlin/Native targets cannot be built on this linux_x64 machine and are disabled:
    * In project ':core':
        * targets 'macosX64', 'macosArm64', 'iosArm32', 'iosArm64', 'iosX64', 'iosSimulatorArm64', 'tvosArm64', 'tvosX64', 'tvosSimulatorArm64', 'watchosArm32', 'watchosArm64', 'watchosX86', 'watchosX64', 'watchosSimulatorArm64' (can be built with one of the hosts: macos_x64, macos_arm64)
    * In project ':extensions':
        * targets 'macosX64', 'macosArm64', 'iosArm32', 'iosArm64', 'iosX64', 'iosSimulatorArm64', 'tvosArm64', 'tvosX64', 'tvosSimulatorArm64', 'watchosArm32', 'watchosArm64', 'watchosX86', 'watchosX64', 'watchosSimulatorArm64' (can be built with one of the hosts: macos_x64, macos_arm64)
To hide this message, add 'kotlin.native.ignoreDisabledTargets=true' to the Gradle properties.

could it be this only works on a mac?

@luca992
Copy link
Contributor Author

luca992 commented May 17, 2023

Thanks and sorry for the very late review. But the build fails for me with:


Some Kotlin/Native targets cannot be built on this linux_x64 machine and are disabled:
    * In project ':core':
        * targets 'macosX64', 'macosArm64', 'iosArm32', 'iosArm64', 'iosX64', 'iosSimulatorArm64', 'tvosArm64', 'tvosX64', 'tvosSimulatorArm64', 'watchosArm32', 'watchosArm64', 'watchosX86', 'watchosX64', 'watchosSimulatorArm64' (can be built with one of the hosts: macos_x64, macos_arm64)
    * In project ':extensions':
        * targets 'macosX64', 'macosArm64', 'iosArm32', 'iosArm64', 'iosX64', 'iosSimulatorArm64', 'tvosArm64', 'tvosX64', 'tvosSimulatorArm64', 'watchosArm32', 'watchosArm64', 'watchosX86', 'watchosX64', 'watchosSimulatorArm64' (can be built with one of the hosts: macos_x64, macos_arm64)
To hide this message, add 'kotlin.native.ignoreDisabledTargets=true' to the Gradle properties.

could it be this only works on a mac?

You can't build mac binaries without a mac. But that shouldn't cause an error, are you sure that's not a warning?

@ligi
Copy link
Member

ligi commented May 17, 2023

you are correct - was just a warning - thanks!

@ligi ligi merged commit fe8e8ed into komputing:master May 17, 2023
@BierDav
Copy link
Contributor

BierDav commented May 17, 2023

The current release 1.1.3 doesn't seem to include all the added native targets.
image

But this is required for komputing/KHash#23

@ligi
Copy link
Member

ligi commented May 17, 2023

guess this needs some work on workflows so these targets are build on mac workers - unfortuntately I do not really have time to work on this - but would merge PRs in this direction

@BierDav
Copy link
Contributor

BierDav commented May 17, 2023

👍 would you please give me a clue how to get the gradle publish to work in my fork? https://github.com/BierDav/KHex

ligi pushed a commit to komputing/KHash that referenced this pull request May 18, 2023
* update .gitignore with gradle template

* update to kotlin 1.6.21, bignum 0.3.4 and gradle 7.4.2

* use new memory model

* add native targets

requires pr: komputing/KHex#14

* kotlin 1.8.21 update dependencies

* remove depreciated native targets, add linuxArm64

* fix depreciated warnings

* gradle 8.1.1
ligi pushed a commit to komputing/KHash that referenced this pull request May 18, 2023
* update .gitignore with gradle template

* update to kotlin 1.6.21, bignum 0.3.4 and gradle 7.4.2

* use new memory model

* add native targets

requires pr: komputing/KHex#14

* Update KHex version
Fix broken gradle.properties import
Fix broken KHex import in build-src

* Bump KHex version to 1.1.4
Bump KGP version to 1.8.21
Remove deprecated native targets
Remove previously accidentally added line of code in build.gradle.kts
Use macos as run target for all automations

* Double workflow timout

* Bump KHex version to expected version 1.1.5

* According to @Deprecation Annotation for legacy and IR compiler support (BOTH), switching to IR only

Probably safe, because the user base for legacy is very limited

Remove deprecated code, that shouldn't be necessary anymore due to the removal in the official JetBrains documentation

* Update README.md

* Remove --info attribute for less verbose CI outputs

* Double workflow timeouts

---------

Co-authored-by: Luca Spinazzola <[email protected]>
Co-authored-by: David Bieregger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants