Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use macos as run target for all automations, Double workflow timeouts #19

Merged
merged 13 commits into from
May 17, 2023
Merged

Use macos as run target for all automations, Double workflow timeouts #19

merged 13 commits into from
May 17, 2023

Conversation

BierDav
Copy link
Contributor

@BierDav BierDav commented May 17, 2023

No description provided.

ligi
ligi requested changes May 17, 2023
View reviewed changes
Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things in yarn.lock looks like merge conflicts

@BierDav
Copy link
Contributor Author

BierDav commented May 17, 2023

jup, wait i'm on it

@BierDav
Copy link
Contributor Author

BierDav commented May 17, 2023

This should be it, i hope ;)

@BierDav BierDav requested a review from ligi May 17, 2023 21:29
@ligi
Copy link
Member

ligi commented May 17, 2023

Nice - yeah - LGTM -Big up! Will merge and release when CI is happy

@BierDav
Copy link
Contributor Author

BierDav commented May 17, 2023

image
I have stumpled upon this. This might be a bit a deal breaker, but I don't think that there is really another solution if we want to run unit tests also for native targets

@BierDav
Copy link
Contributor Author

BierDav commented May 17, 2023

Ahh ok, nevermind for public repositories there is no limit and everything is free anyways.

@ligi
Copy link
Member

ligi commented May 17, 2023

yeah - tbh if it costs I would remove macOS stuff (not using any of these on my own)
maybe we can mitigate by building linux and win stuff on linux worker (as far as I see this might be possible)
and only mcOS stuff on mc workers

@BierDav
Copy link
Contributor Author

BierDav commented May 17, 2023

i don't think that this is worth the effort, because we only have two targets which can be compiled and tested on linux

@ligi ligi merged commit ab2cd86 into komputing:master May 17, 2023
@ligi
Copy link
Member

ligi commented May 17, 2023

I might still do that at some point - just do not trust these closed source machines ..-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ligi ligi Awaiting requested review from ligi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BierDav @ligi