sast-unicode-check: add support for Trusted Artifacts #1524
+321
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok-to-test |
|
@kdudka The script doesn't take care of the OWNERS files though. Still need to add manually. |
kdudka
force-pushed
the
sast-unicode-check-oci-ta
branch
from
9e60dab
to
838778b
Compare
|
@rhyw Added. Thanks for the notice! |
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Oct 24, 2024
Before this change, the `sast-unicode-check` was failing with the
default parameters because the script was passing the whole list
of arguments as a single argument:
```
+ mapfile -t fuc_args
+ LANG=en_US.utf8
+ ./find-unicode-control/find_unicode_control.py '-p bidi -v -d -t' /var/workdir/source
+ FUC_EXIT_CODE=2
+ [[ 2 -ne 0 ]]
+ [[ 2 -ne 1 ]]
+ echo 'Failed to run find-unicode-control command'
Failed to run find-unicode-control command
+ cat raw_sast_unicode_check_out.log
usage: find_unicode_control.py [-h] [-p {all,bidi}] [-v] [-d] [-t] [-c CONFIG]
path [path ...]
find_unicode_control.py: error: argument -p/--nonprint: invalid choice: ' bidi -v -d -t' (choose from 'all', 'bidi')
+ note='Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.'
++ make_result_json -r ERROR -t 'Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.'
```
Fixes: konflux-ci#1401
Related: konflux-ci#1524
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Oct 24, 2024
Create the `-oci-ta` variant of the `sast-unicode-check` task. Related: konflux-ci#1401 Resolves: https://issues.redhat.com/browse/OSH-764 Closes: konflux-ci#1524
kdudka
force-pushed
the
sast-unicode-check-oci-ta
branch
from
838778b
to
31de817
Compare
|
I have tested this via https://github.com/kdudka/konflux-test-ec-cli/pull/1/checks?check_run_id=31993329561. |
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Oct 24, 2024
Before this change, the `sast-unicode-check` was failing with the
default parameters because the script was passing the whole list
of arguments as a single argument:
```
+ mapfile -t fuc_args
+ LANG=en_US.utf8
+ ./find-unicode-control/find_unicode_control.py '-p bidi -v -d -t' /var/workdir/source
+ FUC_EXIT_CODE=2
+ [[ 2 -ne 0 ]]
+ [[ 2 -ne 1 ]]
+ echo 'Failed to run find-unicode-control command'
Failed to run find-unicode-control command
+ cat raw_sast_unicode_check_out.log
usage: find_unicode_control.py [-h] [-p {all,bidi}] [-v] [-d] [-t] [-c CONFIG]
path [path ...]
find_unicode_control.py: error: argument -p/--nonprint: invalid choice: ' bidi -v -d -t' (choose from 'all', 'bidi')
+ note='Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.'
++ make_result_json -r ERROR -t 'Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.'
```
Fixes: konflux-ci#1401
Related: konflux-ci#1524
kdudka
force-pushed
the
sast-unicode-check-oci-ta
branch
from
31de817
to
00a6289
Compare
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Oct 24, 2024
Create the `-oci-ta` variant of the `sast-unicode-check` task. Related: konflux-ci#1401 Resolves: https://issues.redhat.com/browse/OSH-764 Closes: konflux-ci#1524
Before this change, the `sast-unicode-check` was failing with the
default parameters because the script was passing the whole list
of arguments as a single argument:
```
+ mapfile -t fuc_args
+ LANG=en_US.utf8
+ ./find-unicode-control/find_unicode_control.py '-p bidi -v -d -t' /var/workdir/source
+ FUC_EXIT_CODE=2
+ [[ 2 -ne 0 ]]
+ [[ 2 -ne 1 ]]
+ echo 'Failed to run find-unicode-control command'
Failed to run find-unicode-control command
+ cat raw_sast_unicode_check_out.log
usage: find_unicode_control.py [-h] [-p {all,bidi}] [-v] [-d] [-t] [-c CONFIG]
path [path ...]
find_unicode_control.py: error: argument -p/--nonprint: invalid choice: ' bidi -v -d -t' (choose from 'all', 'bidi')
+ note='Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.'
++ make_result_json -r ERROR -t 'Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.'
```
Fixes: konflux-ci#1401
Related: konflux-ci#1524
kdudka
force-pushed
the
sast-unicode-check-oci-ta
branch
from
00a6289
to
4a91952
Compare
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Nov 6, 2024
Create the `-oci-ta` variant of the `sast-unicode-check` task. Related: konflux-ci#1401 Resolves: https://issues.redhat.com/browse/OSH-764 Closes: konflux-ci#1524
Create the `-oci-ta` variant of the `sast-unicode-check` task. Related: konflux-ci#1401 Resolves: https://issues.redhat.com/browse/OSH-764 Closes: konflux-ci#1524
kdudka
force-pushed
the
sast-unicode-check-oci-ta
branch
from
4a91952
to
d2836e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create the
-oci-tavariant of thesast-unicode-checktask.Related: #1401
Resolves: https://issues.redhat.com/browse/OSH-764