-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create sbom-utility-scripts image #154
Conversation
a6fd431
to
88d8a2c
Compare
efc4d0b
to
1ab5f8f
Compare
This image contains multiple python scripts that are used in the buildah tasks. This is done so that multiple steps in buildah tasks can be merged. The image contains scripts from the following stages: merge-syft-sboms merge-cachi2-sbom create-purl-sbom create-base-images-sbom NOTE: the "merge_syft_sbom" from the "merge-cachi2-sbom" stage was taken from https://github.com/containerbuildsystem/cachi2/blob/main/utils/merge_syft_sbom.py and renamed to "merge_cachi2_sboms.py". It will be removed from the cachi2 repo and image. STONEBLD-2608 Signed-off-by: mkosiarc <[email protected]>
Associated PR konflux-ci/build-definitions#1291 |
Removing the script from this repo and migrating it to build-tasks-dockerfiles, to a separate image for sbom utility scripts. See konflux-ci/build-tasks-dockerfiles#154 Signed-off-by: mkosiarc <[email protected]>
Removing the script from this repo and migrating it to build-tasks-dockerfiles, to a separate image for sbom utility scripts. See konflux-ci/build-tasks-dockerfiles#154 Signed-off-by: mkosiarc <[email protected]>
Removing the script from this repo and migrating it to build-tasks-dockerfiles, to a separate image for sbom utility scripts. See konflux-ci/build-tasks-dockerfiles#154 Signed-off-by: mkosiarc <[email protected]>
Removing the script from this repo and migrating it to build-tasks-dockerfiles, to a separate image for sbom utility scripts. See konflux-ci/build-tasks-dockerfiles#154 Signed-off-by: mkosiarc <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. A suggestion is to make the input and output files, these scripts operates on, as command line arguments. Then, the SBOM merge flow will be clearer for easier understanding by specifying data exchange files explicitly.
Removing the script from this repo and migrating it to build-tasks-dockerfiles, to a separate image for sbom utility scripts. See konflux-ci/build-tasks-dockerfiles#154 Signed-off-by: mkosiarc <[email protected]>
Adam raised the same issue in konflux-ci/build-definitions#1291 (comment) |
Removing the script from this repo and migrating it to build-tasks-dockerfiles, to a separate image for sbom utility scripts. See konflux-ci/build-tasks-dockerfiles#154 Signed-off-by: mkosiarc <[email protected]>
This image contains multiple python scripts that are used in the buildah tasks. This is done so that multiple steps in buildah tasks can be merged. The image contains scripts from the following stages:
merge-syft-sboms
merge-cachi2-sbom
create-purl-sbom
create-base-images-sbom
NOTE: the "merge_syft_sbom" from the "merge-cachi2-sbom" stage was taken from
https://github.com/containerbuildsystem/cachi2/blob/main/utils/merge_syft_sbom.py and renamed to "merge_cachi2_sboms.py". It will be removed from the cachi2 repo and image.
STONEBLD-2608