fix(KFLUXBUGS-1297): failure for an already successful snapshot (#1281)

The rhtap-demo test suite will sometimes fail due to the integration service lagging when marking a snapshot as succeeded. A test expecting the snapshot in a passing state can fail as a result. Signed-off-by: Josh Everett <[email protected]>
konflux-ci · Aug 1, 2024 · 1d36e70 · 1d36e70
1 parent 2c0c208
commit 1d36e70
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/tests/konflux-demo/konflux-demo.go b/tests/konflux-demo/konflux-demo.go
@@ -321,9 +321,9 @@ var _ = framework.KonfluxDemoSuiteDescribe(Label(devEnvTestLabel), func() {
 
 			When("Integration Test PipelineRun completes successfully", func() {
 				It("should lead to Snapshot CR being marked as passed", func() {
-					snapshot, err = fw.AsKubeAdmin.IntegrationController.GetSnapshot("", pipelineRun.Name, "", fw.UserNamespace)
-					Expect(err).ShouldNot(HaveOccurred())
 					Eventually(func() bool {
+						snapshot, err = fw.AsKubeAdmin.IntegrationController.GetSnapshot("", pipelineRun.Name, "", fw.UserNamespace)
+						Expect(err).ShouldNot(HaveOccurred())
 						return fw.AsKubeAdmin.CommonController.HaveTestsSucceeded(snapshot)
 					}, time.Minute*5, defaultPollingInterval).Should(BeTrue(), fmt.Sprintf("tests have not succeeded for snapshot %s/%s", snapshot.GetNamespace(), snapshot.GetName()))
 				})