Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove fla bull shits code #1302

Merged
merged 1 commit into from
Aug 1, 2024
Merged

fix: Remove fla bull shits code #1302

merged 1 commit into from
Aug 1, 2024

Conversation

flacatus
Copy link
Collaborator

@flacatus flacatus commented Aug 1, 2024

Description

TSIA.

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

Copy link
Member

@psturc psturc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
spectacular commit message
/honk

Copy link

openshift-ci bot commented Aug 1, 2024

@psturc:
goose image

In response to this:

/lgtm
spectacular commit message
/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chmeliik
Copy link
Contributor

chmeliik commented Aug 1, 2024

It's not every day that a PR title in my mailbox makes me click instantly 👏

Copy link

openshift-ci bot commented Aug 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psturc, tnevrlka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@flacatus
Copy link
Collaborator Author

flacatus commented Aug 1, 2024

lets see: who is the best.. openshift ci or konflux ci?

@psturc
Copy link
Member

psturc commented Aug 1, 2024

lets see: who is the best.. openshift ci or konflux ci?

we shouldn't be even triggering openshift-ci jobs on these kind of changes 🤷

Copy link

openshift-ci bot commented Aug 1, 2024

🚨 Error occurred while running the E2E tests, list of failed Spec(s):

  • ➡️ [failed] [It] [upgrade-suite Create users and check their state] Verify AppStudioProvisionedUser [upgrade-verify]
Unexpected error:
    <*errors.StatusError | 0xc000a04820>: 
    usersignups.toolchain.dev.openshift.com "mig-appst" not found
    {
        ErrStatus: {
            TypeMeta: {Kind: "", APIVersion: ""},
            ListMeta: {
                SelfLink: "",
                ResourceVersion: "",
                Continue: "",
                RemainingItemCount: nil,
            },
            Status: "Failure",
            Message: "usersignups.toolchain.dev.openshift.com \"mig-appst\" not found",
            Reason: "NotFound",
            Details: {
                Name: "mig-appst",
                Group: "toolchain.dev.openshift.com",
                Kind: "usersignups",
                UID: "",
                Causes: nil,
                RetryAfterSeconds: 0,
            },
            Code: 404,
        },
    }
occurred
  • ➡️ [failed] [It] [release-pipelines-suite FBC e2e-tests] with FBC hotfix process FBC hotfix post-release verification verifies the fbc release pipelinerun is running and succeeds [release-pipelines, fbc-tests, fbcHotfix]
Error when waiting for a release pipelinerun for release dev-release-team-tenant/fbc-hotfix-app-gyum-7f9hd-d7th6 to finish
Expected success, but got an error:
    <*errors.errorString | 0xc000e8ba90>: 
    Pipelinerun 'managed-wxtb9' didn't succeed
    Logs from failed container 'step-add-contribution': 
    {
      "index_image": {
        "target_index": "quay.io/redhat/redhat----preview-operator-index:v4.12-bz12345-1722525210"
      }
    }
    Creating InternalRequest to add FBC contribution to index image:
    InternalRequest 'iib-tkz8c' created.
    Sync flag set to true. Waiting for the InternalRequest to be completed.
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: running
    Checking IR statuses...
    Found 1 InternalRequests matching the name or label
    Conditions:
      iib-tkz8c: Rejected
    All InternalRequests have been completed
    ERROR: At least one InternalRequest failed
    Conditions:
      iib-tkz8c: [{"lastTransitionTime":"2024-08-01T15:13:34Z","message":"the internal request namespace (managed-release-team-tenant) is not in the allow list","reason":"Rejected","status":"False","type":"Succeeded"}]
    Result: failure
    %!(EXTRA <nil>)
    {
        s: "Pipelinerun 'managed-wxtb9' didn't succeed\nLogs from failed container 'step-add-contribution': \n{\n  \"index_image\": {\n    \"target_index\": \"quay.io/redhat/redhat----preview-operator-index:v4.12-bz12345-1722525210\"\n  }\n}\nCreating InternalRequest to add FBC contribution to index image:\nInternalRequest 'iib-tkz8c' created.\nSync flag set to true. Waiting for the InternalRequest to be completed.\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or label\nConditions:\n  iib-tkz8c: running\nChecking IR statuses...\nFound 1 InternalRequests matching the name or labe...

Gomega truncated this representation as it exceeds 'format.MaxLength'.
Consider having the object provide a custom 'GomegaStringer' representation
or adjust the parameters in Gomega's 'format' package.

Learn more here: https://onsi.github.io/gomega/#adjusting-output

🙈 Link to Pod logs.
🙉 Link to Custom Resources.
🙊 Link to junit-summary.html.


@flacatus: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/redhat-appstudio-e2e b3254a0 link true /test redhat-appstudio-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@flacatus
Copy link
Collaborator Author

flacatus commented Aug 1, 2024

lets see: who is the best.. openshift ci or konflux ci?

we shouldn't be even triggering openshift-ci jobs on these kind of changes 🤷

No worry, from next week we will not! 👿

@flacatus flacatus merged commit 8ce942c into konflux-ci:main Aug 1, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants