Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Use external secret from vault in e2e tests #1308

Merged
merged 7 commits into from
Aug 6, 2024
Merged

chore: Use external secret from vault in e2e tests #1308

merged 7 commits into from
Aug 6, 2024

Conversation

flacatus
Copy link
Collaborator

@flacatus flacatus commented Aug 5, 2024

Description

Usse devshift vault external secrets name

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

@openshift-ci openshift-ci bot requested review from jinqi7 and tisutisu August 5, 2024 07:58
@flacatus flacatus changed the title Use external secret from vault in e2e tests chore: Use external secret from vault in e2e tests Aug 5, 2024
@flacatus
Copy link
Collaborator Author

flacatus commented Aug 5, 2024

/retest

@konflux-ci-qe-bot
Copy link

@flacatus: The following test finished, in case test failed say /retest to rerun all failed tests:

PipelineRun name Command
konflux-e2e-h2jl6-tk6wd /retest

To inspect your test artifacts make sure you have installed ORAS in your local machine. To inspect all test artifacts execute:

mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-qe-incubator/konflux-qe-oci-storage:konflux-e2e-h2jl6-tk6wd

For instructions on how to install ORAS, please refer to the ORAS installation guide.

@konflux-ci-qe-bot
Copy link

@flacatus: The following test finished, in case test failed say /retest to rerun all failed tests:

PipelineRun name Command
konflux-e2e-bvcrx-8cj8b /retest

To inspect your test artifacts make sure you have installed ORAS in your local machine. To inspect all test artifacts execute:

mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-qe-incubator/konflux-qe-oci-storage:konflux-e2e-bvcrx-8cj8b

For instructions on how to install ORAS, please refer to the ORAS installation guide.

@flacatus
Copy link
Collaborator Author

flacatus commented Aug 5, 2024

/retest

@konflux-ci-qe-bot
Copy link

@flacatus: The following test finished, in case test failed say /retest to rerun all failed tests:

PipelineRun name Command
konflux-e2e-8x7kx-nr2cp /retest

To inspect your test artifacts make sure you have installed ORAS in your local machine. To inspect all test artifacts execute:

mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-qe-incubator/konflux-qe-oci-storage:konflux-e2e-8x7kx-nr2cp

For instructions on how to install ORAS, please refer to the ORAS installation guide.

@flacatus
Copy link
Collaborator Author

flacatus commented Aug 5, 2024

/retest

@konflux-ci-qe-bot
Copy link

@flacatus: The following test finished, in case test failed say /retest to rerun all failed tests:

PipelineRun name Command
konflux-e2e-k6zqg-8nx9f /retest

To inspect your test artifacts make sure you have installed ORAS in your local machine. To inspect all test artifacts execute:

mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-qe-incubator/konflux-qe-oci-storage:konflux-e2e-k6zqg-8nx9f

For instructions on how to install ORAS, please refer to the ORAS installation guide.

@flacatus
Copy link
Collaborator Author

flacatus commented Aug 5, 2024

/retest

@konflux-ci-qe-bot
Copy link

@flacatus: The following test finished, in case test failed say /retest to rerun all failed tests:

PipelineRun name Command
konflux-e2e-zmcj9-wnsbp /retest

To inspect your test artifacts make sure you have installed ORAS in your local machine. To inspect all test artifacts execute:

mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-qe-incubator/konflux-qe-oci-storage:konflux-e2e-zmcj9-wnsbp

For instructions on how to install ORAS, please refer to the ORAS installation guide.

@flacatus
Copy link
Collaborator Author

flacatus commented Aug 5, 2024

/retest

@konflux-ci-qe-bot
Copy link

@flacatus: The following test finished, in case test failed say /retest to rerun all failed tests:

PipelineRun name Command
konflux-e2e-k6zqg-n2bxj /retest

To inspect your test artifacts make sure you have installed ORAS in your local machine. To inspect all test artifacts execute:

mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-qe-incubator/konflux-qe-oci-storage:konflux-e2e-k6zqg-n2bxj

For instructions on how to install ORAS, please refer to the ORAS installation guide.

@konflux-ci-qe-bot
Copy link

@flacatus: The following test finished, in case test failed say /retest to rerun all failed tests:

PipelineRun name Command
konflux-e2e-7zsd9-glmll /retest

To inspect your test artifacts make sure you have installed ORAS in your local machine. To inspect all test artifacts execute:

mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-qe-incubator/konflux-qe-oci-storage:konflux-e2e-7zsd9-glmll

For instructions on how to install ORAS, please refer to the ORAS installation guide.

@konflux-ci-qe-bot
Copy link

@flacatus: The following test finished, in case test failed say /retest to rerun all failed tests:

PipelineRun name Command
konflux-e2e-q64r8-lk5k8 /retest

To inspect your test artifacts make sure you have installed ORAS in your local machine. To inspect all test artifacts execute:

mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-qe-incubator/konflux-qe-oci-storage:konflux-e2e-q64r8-lk5k8

For instructions on how to install ORAS, please refer to the ORAS installation guide.

@konflux-ci-qe-bot
Copy link

@flacatus: The following test finished, in case test failed say /retest to rerun all failed tests:

PipelineRun name Command
konflux-e2e-nrgkd-9jb2p /retest

To inspect your test artifacts make sure you have installed ORAS in your local machine. To inspect all test artifacts execute:

mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-qe-incubator/konflux-qe-oci-storage:konflux-e2e-nrgkd-9jb2p

For instructions on how to install ORAS, please refer to the ORAS installation guide.

@flacatus
Copy link
Collaborator Author

flacatus commented Aug 5, 2024

/retest

@konflux-ci-qe-bot
Copy link

@flacatus: The following test finished, in case test failed say /retest to rerun all failed tests:

PipelineRun name Command
konflux-e2e-jm2cg-scrgp /retest

To inspect your test artifacts make sure you have installed ORAS in your local machine. To inspect all test artifacts execute:

mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-qe-incubator/konflux-qe-oci-storage:konflux-e2e-jm2cg-scrgp

For instructions on how to install ORAS, please refer to the ORAS installation guide.

@flacatus
chore: Ussually a task have by default 1h timeout. Increase timeout t…
aec5bd8 
…o 2h (konflux-ci#1306)

Ussually a task have by default 1h timeout. Increase timeout to 2h
@konflux-ci-qe-bot
Copy link

@flacatus: The following test finished, in case test failed say /retest to rerun all failed tests:

PipelineRun name Command
konflux-e2e-2gctf-qthjh /retest

To inspect your test artifacts make sure you have installed ORAS in your local machine. To inspect all test artifacts execute:

mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-qe-incubator/konflux-qe-oci-storage:konflux-e2e-2gctf-qthjh

For instructions on how to install ORAS, please refer to the ORAS installation guide.

@konflux-ci-qe-bot
Copy link

@flacatus: The following test finished, in case test failed say /retest to rerun all failed tests:

PipelineRun name Command
konflux-e2e-cn7pg-dpdms /retest

To inspect your test artifacts make sure you have installed ORAS in your local machine. To inspect all test artifacts execute:

mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-qe-incubator/konflux-qe-oci-storage:konflux-e2e-cn7pg-dpdms

For instructions on how to install ORAS, please refer to the ORAS installation guide.

@konflux-ci-qe-bot
Copy link

@flacatus: The following test finished, in case test failed say /retest to rerun all failed tests:

PipelineRun name Command
konflux-e2e-zqstr-z88xv /retest

To inspect your test artifacts make sure you have installed ORAS in your local machine. To inspect all test artifacts execute:

mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-qe-incubator/konflux-qe-oci-storage:konflux-e2e-zqstr-z88xv

For instructions on how to install ORAS, please refer to the ORAS installation guide.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kasemAlem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 6, 2024
@kasemAlem
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 6, 2024
@flacatus flacatus merged commit 4c97155 into konflux-ci:main Aug 6, 2024
11 of 13 checks passed
This was referenced Aug 6, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasemAlem kasemAlem kasemAlem approved these changes

@jinqi7 jinqi7 Awaiting requested review from jinqi7

@tisutisu tisutisu Awaiting requested review from tisutisu

Assignees

@kasemAlem kasemAlem

Labels
approved lgtm < 1 min
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flacatus @konflux-ci-qe-bot @kasemAlem