Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RELEASE-1172): add a mage engine rule for release-service #1394

Merged
merged 19 commits into from
Sep 23, 2024

Conversation

jinqi7
Copy link
Contributor

@jinqi7 jinqi7 commented Sep 18, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

Copy link

openshift-ci bot commented Sep 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jinqi7 jinqi7 marked this pull request as ready for review September 19, 2024 01:52
@jinqi7
Copy link
Contributor Author

jinqi7 commented Sep 19, 2024

/retest

@jinqi7
Copy link
Contributor Author

jinqi7 commented Sep 19, 2024

/retest

1 similar comment
@jinqi7
Copy link
Contributor Author

jinqi7 commented Sep 19, 2024

/retest

@psturc
Copy link
Member

psturc commented Sep 20, 2024

/test redhat-appstudio-e2e

1 similar comment
@jinqi7
Copy link
Contributor Author

jinqi7 commented Sep 20, 2024

/test redhat-appstudio-e2e

@jinqi7
Copy link
Contributor Author

jinqi7 commented Sep 20, 2024

/retest

1 similar comment
@jinqi7
Copy link
Contributor Author

jinqi7 commented Sep 23, 2024

/retest

@flacatus
Copy link
Collaborator

bug fixed, lets retest

/retest

@jinqi7
Copy link
Contributor Author

jinqi7 commented Sep 23, 2024

/retest

Copy link
Member

@psturc psturc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psturc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@flacatus
Copy link
Collaborator

/retest

Copy link

openshift-ci bot commented Sep 23, 2024

@jinqi7: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/redhat-appstudio-e2e 0017208 link false /test redhat-appstudio-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 33d5d13 into konflux-ci:main Sep 23, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants