Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip creating multiple component for symlink test #1396

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

tisutisu
Copy link
Contributor

Description

Observed that multiple component/pipelineruns getting created for the symlink component test after this PR got merged, we expect to run symlink component with only one pipeline bundle docker-build, since it is just a negative scenario

Issue ticket number and link

NA

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Locally

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

Copy link
Contributor

@lcarva lcarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lcarva
Copy link
Contributor

lcarva commented Sep 19, 2024

Multi-arch test failing with:

#no server could be provisioned

@lcarva
Copy link
Contributor

lcarva commented Sep 19, 2024

/retest

@lcarva
Copy link
Contributor

lcarva commented Sep 19, 2024

/retest

ORAS artifacts are incomplete. I'm unable to tell what the failure was.

@lcarva
Copy link
Contributor

lcarva commented Sep 19, 2024

Same error as before:

#no server could be provisioned

Is the multi-platform operator not working as expected?

@lcarva
Copy link
Contributor

lcarva commented Sep 19, 2024

Yeah, there's something up with the multi-platform operator. I'm seeing this in the logs:

2024-09-19T18:09:14Z    ERROR   controller/controller.go:329    Reconciler error        {"controller": "taskrun", "controllerGroup": "tekton.dev", "controllerKind": "TaskRun", "TaskRun": {"name":"test-comp-vmkl-on-pull-request-l9654-build-images-1","namespace":"build-e2e-qbcb-tenant"}, "namespace": "build-e2e-qbcb-tenant", "name": "test-comp-vmkl-on-pull-request-l9654-build-images-1", "reconcileID": "3967f9cb-99d7-47dd-ae0c-f6452ca58736", "error": "ConfigMap \"host-config\" not found"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
        /opt/app-root/src/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:329
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
        /opt/app-root/src/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
        /opt/app-root/src/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:227

@tisutisu
Copy link
Contributor Author

tisutisu commented Sep 20, 2024

Yeah, there's something up with the multi-platform operator. I'm seeing this in the logs:

2024-09-19T18:09:14Z    ERROR   controller/controller.go:329    Reconciler error        {"controller": "taskrun", "controllerGroup": "tekton.dev", "controllerKind": "TaskRun", "TaskRun": {"name":"test-comp-vmkl-on-pull-request-l9654-build-images-1","namespace":"build-e2e-qbcb-tenant"}, "namespace": "build-e2e-qbcb-tenant", "name": "test-comp-vmkl-on-pull-request-l9654-build-images-1", "reconcileID": "3967f9cb-99d7-47dd-ae0c-f6452ca58736", "error": "ConfigMap \"host-config\" not found"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
        /opt/app-root/src/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:329
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
        /opt/app-root/src/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
        /opt/app-root/src/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:227

I think to run the "docker-build-multi-platform-oci-ta" pipeline in e2e-tests CI, we have to configure "host-config" configMap needed by multi-platform-controller. Skipping it temporarily in the current PR to unblock CI,

Copy link

openshift-ci bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kasemAlem, lcarva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kasemAlem
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 23, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ac8604b into konflux-ci:main Sep 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants