Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add docker secret to tekton-results and minio #1406

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

psturc
Copy link
Member

@psturc psturc commented Sep 25, 2024

Description

I saw the docker pull issue in test cluster recently
Screenshot 2024-09-25 at 18 55 03

it affected not only the minio-operator ns, but also tekton-results

This PR adds docker pull secret to both of those namespaces to avoid the docker pull limit issue

Issue ticket number and link

N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

in CI 🤷

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

Copy link

openshift-ci bot commented Sep 25, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from psturc. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@psturc
Copy link
Member Author

psturc commented Sep 25, 2024

/retest

1 similar comment
@psturc
Copy link
Member Author

psturc commented Sep 25, 2024

/retest

@psturc
Copy link
Member Author

psturc commented Sep 26, 2024

/retest

@psturc
Copy link
Member Author

psturc commented Sep 26, 2024

the configuration worked in the pipeline here

[2024-09-26 05:17:16] [INFO] running tests with github user: redhat-appstudio-qe-bot
Saved credentials for docker.io into ./global-pull-secret.json
namespace/minio-operator created
serviceaccount/minio-operator created
secret/pull-secret created
secret/pull-secret data updated
namespace/tekton-results created
serviceaccount/storage-sa created
secret/pull-secret created
secret/pull-secret data updated

marking as ready for a review

@psturc psturc marked this pull request as ready for review September 26, 2024 05:41
@konflux-ci-qe-bot
Copy link

@psturc: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
konflux-e2e-6lvw6-t5cf6 Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/konflux-team/e2e-tests:konflux-e2e-6lvw6-t5cf6

@flacatus
Copy link
Collaborator

/lgtm

@psturc
Copy link
Member Author

psturc commented Sep 26, 2024

failed on

[e2e-test]   �[38;5;9m[FAIL]�[0m �[0m[build-service-suite Build service E2E tests] �[38;5;243mtest PaC component build �[0mgitlab �[38;5;243mwhen the PaC init branch is merged �[38;5;9m�[1m[It] After updating image visibility to private, it should not trigger another PipelineRun�[0m �[38;5;204m[build-service, github-webhook, pac-build, pipeline, image-controller, build-custom-branch]�[0m

which is unrelated to this PR

@psturc
Copy link
Member Author

psturc commented Sep 26, 2024

merging, because this should unblock other PRs hitting an issue with docker pull rate limit

@psturc psturc merged commit 1a2e878 into konflux-ci:main Sep 26, 2024
11 of 13 checks passed
@psturc psturc deleted the docker-creds-to-more-ns branch September 26, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants