Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use finalizer lock in EC build-definitions #1415

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

zregvart
Copy link
Member

@zregvart zregvart commented Oct 3, 2024

Description

The EC test in build-definitions was failing because the PipelineRun was garbage collected mid-test, so the logs that are asserted were not available.
This uses a finalizer lock on the PipelineRun to make sure it is still present while the logs are asserted in the test scenario.

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Ran with this version in build-definitions on konflux-ci/build-definitions#1460

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

The EC test in build-definitions was failing because the PipelineRun was
garbage collected mid-test, so the logs that are asserted were not
available.
This uses a finalizer lock on the PipelineRun to make sure it is still
present while the logs are asserted in the test scenario.
Copy link
Member

@psturc psturc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 3, 2024
@psturc psturc merged commit b1bb741 into konflux-ci:main Oct 3, 2024
12 of 13 checks passed
Copy link

openshift-ci bot commented Oct 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcarva, psturc, simonbaird

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants