Skip to content

Commit

Permalink
🌱 simplify dotnet provider builds (#569)
Browse files Browse the repository at this point in the history
Signed-off-by: David Zager <[email protected]>
  • Loading branch information
djzager authored Apr 8, 2024
1 parent 988268d commit b8e8ebf
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/image-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,18 @@ jobs:
TAG=${GITHUB_REF_NAME/main/latest}
sed -i "s,FROM quay.io/konveyor/jdtls-server-base,FROM quay.io/konveyor/jdtls-server-base:${TAG}," Dockerfile
context: "."
architectures: '[ "amd64", "arm64", "ppc64le", "s390x" ]'
- name: dotnet-external-provider
containerfile: "./external-providers/dotnet-external-provider/Dockerfile"
context: "./external-providers/dotnet-external-provider"
architectures: '[ "amd64", "arm64" ]'
uses: konveyor/release-tools/.github/workflows/build-push-images.yaml@main
with:
registry: "quay.io/konveyor"
image_name: ${{ matrix.images.name }}
containerfile: ${{ matrix.images.containerfile }}
pre_build_cmd: ${{ matrix.images.pre_build_cmd }}
architectures: '[ "amd64", "arm64", "ppc64le", "s390x" ]'
architectures: ${{ matrix.images.architectures }}
context: ${{ matrix.images.context }}
secrets:
registry_username: ${{ secrets.QUAY_PUBLISH_ROBOT }}
Expand Down
3 changes: 1 addition & 2 deletions external-providers/dotnet-external-provider/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ COPY pkg/ ./pkg
RUN go mod download

RUN make build
RUN ADD_PLAT=yes OS=windows ARCH=amd64 make build
RUN ADD_PLAT=yes OS=windows ARCH=arm64 make build
RUN ADD_PLAT=yes OS=windows make build

# TODO(djzager): resurrect if we need omnisharp-roslyn
# FROM registry.access.redhat.com/ubi8/dotnet-70 AS builder
Expand Down

0 comments on commit b8e8ebf

Please sign in to comment.