Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to query on annotation information #460

Closed
jmle opened this issue Jan 5, 2024 · 1 comment
Closed

Add the ability to query on annotation information #460

jmle opened this issue Jan 5, 2024 · 1 comment
Assignees
@jmle
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. provider/java
Milestone
v0.5.0

Comments

@jmle
Copy link
Contributor

jmle commented Jan 5, 2024

In windup, it is possible to further inspect an annotation in a condition as in here (see the docs). It would be good to investigate if something similar can be achieved with the LS.

At the moment we are not translating those attributes of the original rules.
@dymurray dymurray added this to the v0.5.0 milestone Jun 11, 2024
@dymurray dymurray changed the title [RFE] Add the ability to query on annotation information Add the ability to query on annotation information Jun 20, 2024
@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 20, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Jun 20, 2024
@jmle jmle mentioned this issue Jun 20, 2024
Closed
@dymurray dymurray added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/bug Categorizes issue or PR as related to a bug. labels Jun 26, 2024
@konveyor-ci-bot konveyor-ci-bot bot removed needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Jun 26, 2024
@jmle jmle mentioned this issue Jul 16, 2024
Merged
shawn-hurley pushed a commit that referenced this issue Jul 22, 2024
@jmle
🐛 Add annotation inspection support (#659)
4fdf5e5 
This PR adds support for inspecting annotations.

:green_circle: Things that can be done now:
- Check for annotations that are annotating specific
`FIELD_DECLARATION`, `METHOD_DECLARATION` or `TYPE`
- Match against `METHOD_DECLARATION`

:red_circle: Things that cannot be done **yet**:
- Match `location: ANNOTATION` and inspect its values.
- Inspect on annotations on `location: CONSTRUCTOR`.

Depends on:
- konveyor/java-analyzer-bundle#104

Fixes:
- #460
- #467

---------

Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
@jmle jmle closed this as completed Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmle jmle

Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. provider/java
Projects
Planning
Status: ✅ Done
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

🐛 Temptative solution for basic annotation inspection jmle/analyzer-lsp
3 participants
@jmle @pranavgaikwad @dymurray