Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Code snippet not available in XML files when a match is the key of the node itself and not the value of it #503

Closed
1 task done
pranavgaikwad opened this issue Feb 13, 2024 · 2 comments · Fixed by #504
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@pranavgaikwad
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

v0.3.0

Priority

Minor

Current Behavior

No code snippet available for match from beans.xml file in the project.

Example rule:

- category: potential
  customVariables: []
  description: '`beans.xml` descriptor content is ignored'
  effort: 3
  labels:
  - konveyor.io/source=java-ee
  - konveyor.io/target=quarkus
  links: []
  message: "\n `beans.xml` descriptor content is ignored and it could be removed from
    the application. \n Refer to the guide referenced below to check the supported
    CDI feature in Quarkus.\n "
  ruleID: cdi-to-quarkus-00030
  when:
    as: root
    builtin.xml:
      filepaths:
      - beans.xml
      namespaces:
        b: http://xmlns.jcp.org/xml/ns/javaee
      xpath: /b:beans

Example app: https://github.com/WASdev/sample.daytrader7

Expected Behavior

Code snippet around Line no 17 should be present.

How Reproducible

Always (Default)

Steps To Reproduce

See example rule and app above, it should return code snippet surrounding line 17

Environment

- **Analyzer Image SHA** 
- **JDTLS  base image SHA**
- **Provider Settings JSON**

Anything else?

No response

@pranavgaikwad pranavgaikwad added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 13, 2024
@pranavgaikwad pranavgaikwad self-assigned this Feb 13, 2024
@pranavgaikwad pranavgaikwad added this to the v0.3.1 milestone Feb 13, 2024
@pranavgaikwad
Copy link
Contributor Author

/triage accepted
/priority backlog

@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Feb 13, 2024
@pranavgaikwad pranavgaikwad added priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Feb 14, 2024
shawn-hurley pushed a commit that referenced this issue Feb 20, 2024
…not an inner value (#504)

Fixes #503

---------

Signed-off-by: Pranav Gaikwad <[email protected]>
Co-authored-by: David Zager <[email protected]>
pranavgaikwad added a commit to pranavgaikwad/analyzer-lsp that referenced this issue Feb 21, 2024
…not an inner value (konveyor#504)

Fixes konveyor#503

---------

Signed-off-by: Pranav Gaikwad <[email protected]>
Co-authored-by: David Zager <[email protected]>
pranavgaikwad added a commit that referenced this issue Feb 21, 2024
Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
Co-authored-by: Juan Manuel Leflet Estrada <[email protected]>
Co-authored-by: David Zager <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: ✅ Done
1 participant