Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary --name argument is being passed to all GRPC provider servers #513

Open
pranavgaikwad opened this issue Feb 20, 2024 · 2 comments
Open

Unnecessary --name argument is being passed to all GRPC provider servers #513

pranavgaikwad opened this issue Feb 20, 2024 · 2 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
Next

Comments

@pranavgaikwad
Copy link
Contributor

In addition to --port, we are now passing --name flag to GRPC provider servers at the time of running Start(). If the external provider doesn't handle this argument well, it can make the provider fail. --name is only needed in the generic provider to differentiate between which underlying lsp provider is being used...I think its unnecessary in the context of all GRPC providers.
@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 20, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Feb 20, 2024
@pranavgaikwad pranavgaikwad added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Feb 20, 2024
@pranavgaikwad
Copy link
Contributor Author

/triage accepted
/kind cleanup

@konveyor-ci-bot konveyor-ci-bot bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. labels Feb 20, 2024
@pranavgaikwad pranavgaikwad mentioned this issue Feb 20, 2024
Merged
pranavgaikwad added a commit that referenced this issue Feb 20, 2024
@pranavgaikwad @JonahSussman
✨ Refactor generic-external-provider (#512)
ea6ca68 
Clone of #387

We needed this fix
b2df101

Follow up issue created in
#513

---------

Signed-off-by: JonahSussman <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
Co-authored-by: JonahSussman <[email protected]>
@pranavgaikwad pranavgaikwad added this to the Next milestone Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning
Status: 📋 Backlog
Milestone
Next
Development

No branches or pull requests
1 participant
@pranavgaikwad