Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] War file class files are not correctly identified in Dependencies #533

Closed
1 task done
shawn-hurley opened this issue Mar 12, 2024 · 0 comments · Fixed by #553
Closed
1 task done

[BUG] War file class files are not correctly identified in Dependencies #533

shawn-hurley opened this issue Mar 12, 2024 · 0 comments · Fixed by #553
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@shawn-hurley
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

--all-

Priority

Major

Current Behavior

Currently, when decompiling a war file, we handle WEB-INF/lib/*.jar files correctly, but you can have a WEB-INF/classes/<dirss>/*.classes and you can have WEB-INF/<dirs>/*.classes. Currently, we do find and decompile these files, and will search them, but we are unable to determine the dependency that they come from.

Expected Behavior

We should be able to tell from the the dependency groupId and ArtifactId. This should be used when getting violations/incidents from these decompiled classes to determine if they should be present based on dependency label selector.

How Reproducible

Always (Default)

Steps To Reproduce

No response

Environment

- **Analyzer Image SHA** 
- **JDTLS  base image SHA**
- **Provider Settings JSON**

Anything else?

No response

@shawn-hurley shawn-hurley added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 12, 2024
@konveyor-ci-bot konveyor-ci-bot bot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 12, 2024
@shawn-hurley shawn-hurley self-assigned this Mar 13, 2024
@pranavgaikwad pranavgaikwad added this to the v0.4.0 milestone Mar 19, 2024
shawn-hurley added a commit that referenced this issue Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants