🐛 Adding test to make sure that we don't find match in doc comment #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawn-hurley
force-pushed
the
bugfix/issue-361
branch
from
7cde4cb
to
b0d42d4
Compare
Signed-off-by: Shawn Hurley <[email protected]>
shawn-hurley
force-pushed
the
bugfix/issue-361
branch
from
b0d42d4
to
e492e55
Compare
|
After running the windup shim locally: I think that we really should consider this, as it reduces the calls being made and the number of dups that we are finding and removing. I think it generally is working more efficiently. |
shawn-hurley
requested review from
pranavgaikwad and
fabianvf
and removed request for
pranavgaikwad
pranavgaikwad
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #361
requires konveyor/java-analyzer-bundle#75