🐛 Use window of correct size in presence of newlines to grab content from xml files #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavgaikwad
changed the title
Signed-off-by: Pranav Gaikwad <[email protected]>
shawn-hurley
reviewed
Jan 8, 2024
| lines = append(lines, line) | ||
| } | ||
| // remove leading and trailing empty lines | ||
| if len(lines) > 0 && lines[0] == "" { |
There was a problem hiding this comment.
Is there a time/place where you can have content that is 5 empty lines?
There was a problem hiding this comment.
@shawn-hurley content comes from innerText returned by the XML search, and it depends on the xml query, so theoritically it's possible if someone is intentionally / mistakenly looking for empty lines. in that case, we will end up showing empty lines as code snip
There was a problem hiding this comment.
What if as we loop, as long as one thing has content, then we use it, if all don't then we skip it?
Signed-off-by: Pranav Gaikwad <[email protected]>
pranavgaikwad
commented
Jan 9, 2024
| if len(lines) > 0 && lines[len(lines)-1] == "" { | ||
| lines = lines[:len(lines)-1] | ||
| } | ||
| if len(lines) < 1 || strings.Join(lines, "") == "" { |
There was a problem hiding this comment.
@shawn-hurley this check should take care of the empty case
pranavgaikwad
added
the
cherry-pick/release-0.3
github-actions bot
pushed a commit
that referenced
this pull request
Jan 9, 2024
…from xml files (#461) We are stripping out empty lines when doing the search, however, in the window that we load into memory we still have to load these empty lines to be able to correctly search content. We only have to get rid of newlines from beginning and the end. --------- Signed-off-by: Pranav Gaikwad <[email protected]>
pranavgaikwad
added a commit
that referenced
this pull request
Jan 9, 2024
…from xml files (#461) (#462) We are stripping out empty lines when doing the search, however, in the window that we load into memory we still have to load these empty lines to be able to correctly search content. We only have to get rid of newlines from beginning and the end. --------- Signed-off-by: Pranav Gaikwad <[email protected]> Signed-off-by: Pranav Gaikwad <[email protected]> Co-authored-by: Pranav Gaikwad <[email protected]>
This was referenced May 8, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are stripping out empty lines when doing the search, however, in the window that we load into memory we still have to load these empty lines to be able to correctly search content. We only have to get rid of newlines from beginning and the end.