Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👻 Deleted demo-rules directory #493

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

UtkarshUmre
Copy link
Contributor

deleted demo-rules directory which is no longer needed

fixes #480

deleted demo-rules directory which is no longer in use

Signed-off-by: UtkarshUmre <[email protected]>
@jmle
Copy link
Contributor

jmle commented Feb 7, 2024

@UtkarshUmre take a look at the failing check - the PR title must begin with an icon. Looks good apart from that

@pranavgaikwad pranavgaikwad changed the title Deleted demo-rules directory 👻 Deleted demo-rules directory Feb 7, 2024
@UtkarshUmre
Copy link
Contributor Author

Yup @jmle I just saw it and was about to make the changes. Thanks to @pranavgaikwad for helping.

@jmle jmle merged commit d4499bf into konveyor:main Feb 7, 2024
6 of 7 checks passed
@jmle
Copy link
Contributor

jmle commented Feb 7, 2024

@UtkarshUmre thank you for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demo rules under demo-rules directory should be removed
2 participants