🐛 respect match-all label values #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pranav Gaikwad <[email protected]>
pranavgaikwad
added
the
cherry-pick/release-0.3
shawn-hurley
requested changes
Feb 7, 2024
There was a problem hiding this comment.
This behavior feels wrong to me, if someone sets a source they want, we should still limit to that source. if they want any sources, then they should have a selector that allows for it konveyor.io/source || konveyor.io/source=A will give you any rules that have the source label with no value, as well as rules with source value at A.
Unless I am missing something?
|
@shawn-hurley based on our discussion offline, are you convinced that this is correct or you are still looking for changes? |
shawn-hurley
approved these changes
Feb 12, 2024
|
@shawn-hurley I will update documentation in this PR itself |
Signed-off-by: Pranav Gaikwad <[email protected]>
|
@shawn-hurley updated docs now. |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 12, 2024
Signed-off-by: Pranav Gaikwad <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
pranavgaikwad
added a commit
that referenced
this pull request
Feb 12, 2024
Signed-off-by: Pranav Gaikwad <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Signed-off-by: Pranav Gaikwad <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Co-authored-by: Pranav Gaikwad <[email protected]>
This was referenced May 8, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.