🐛 handle correct structs for protobof init calls #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding validation of the keys in provider specific config to only be strings Adding test cases to validate both json and yaml provider settings files will work Signed-off-by: Shawn Hurley <[email protected]>
eemcmullan
approved these changes
Mar 19, 2024
djzager
approved these changes
Mar 20, 2024
aufi
pushed a commit
to aufi/analyzer-lsp
that referenced
this pull request
Mar 25, 2024
Adding validation of the keys in provider-specific config to only be strings Adding test cases to validate both JSON and yaml provider settings files will work. fixes konveyor#501 Signed-off-by: Shawn Hurley <[email protected]>
This was referenced May 8, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding validation of the keys in provider-specific config to only be strings
Adding test cases to validate both JSON and yaml provider settings files will work.
fixes #501