✨ Adding optional TLS for provider communication #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shawn Hurley <[email protected]>
shawn-hurley
requested review from
djzager,
eemcmullan and
pranavgaikwad
and removed request for
djzager and
eemcmullan
eemcmullan
approved these changes
May 15, 2024
shawn-hurley
changed the title
|
@pranavgaikwad @eemcmullan @djzager I want to point out that this is not authentication, just that it uses certs to encrypt traffic over the wire. This is obviously strictly better but I don't think fully covers the full story. |
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding for all the in-tree providers the ability to use TLS authentication