Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add analysis insights #618

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

pranavgaikwad
Copy link
Contributor

@pranavgaikwad pranavgaikwad commented Jun 12, 2024

What creates Insights?

Rules that do not have an effort value defined or have an effort value of 0, will generate insights.

Depending on what rule actions they define, the output will look different. See following table for all scenarios:

.effort .tag .message Description
0 Defined Not Defined Rule creates tags and an insight. Insight does not contain message.
0 Defined Defined Rule creates tags and an insight. Insight contains message.
0 Not Defined Defined Rule creates an insight. Insight contains message.
1 Defined Defined Rule creates tags and a violation. No insights here as effort is non-zero.

See https://github.com/konveyor/enhancements/edit/master/enhancements/analysis-insights/README.md

Signed-off-by: Pranav Gaikwad <[email protected]>
Copy link
Contributor

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am really happy how clean this patch looks for this!

@pranavgaikwad pranavgaikwad merged commit e2284ce into konveyor:main Jun 12, 2024
10 checks passed
@pranavgaikwad
Copy link
Contributor Author

@shawn-hurley thanks to you and @fabianvf who designed the engine this way. all I had to do is change how we were creating incidents

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants