✨ Make providers return a builtin config so engine can look at updated locations #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavgaikwad
added
the
do-not-merge/hold
shawn-hurley
approved these changes
Jul 2, 2024
pranavgaikwad
force-pushed
the
main
branch
3 times, most recently
from
11a1557
to
f416c21
Compare
pranavgaikwad
force-pushed
the
main
branch
5 times, most recently
from
ac5074f
to
00cb578
Compare
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some providers can mutate the original location given in init config. For example, for binaries, java provider decompiles and uses the new decompiled path. This PR adds a way for providers to communicate updated locations back to the engine so builtin provider can be configured correctly without the user having to do it.