Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Windows Compatibility-Add PowerShell Script as an Alternative to Grep on Linux #690

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kthatipally
Copy link

PR Summary
This pull request introduces a PowerShell-based alternative to the grep command, ensuring that the built-in File Searching feature is also compatible with Windows systems.

service_client.go: Added runOSSpecificGrepCommand to handle grep functionality for both Windows (using PowerShell) and Unix-based systems. This function checks for the OS platform and invokes powershell(windows) and grep(linux). Replaced direct grep command execution with runOSSpecificGrepCommand to support cross-platform compatibility.

service_client.go: Implemented parseGrepOutputForFileContent to parse the output from both PowerShell and grep. This enhancement not only refines the existing parsing mechanism for Linux but also accommodates Windows file path patterns and addresses issues with the split function when multiple ':' appear in the input.

WIP: Testing

@kthatipally kthatipally changed the title [Windows Compatibility] Add PowerShell Script as an Alternative to Grep on Linux Non-breaking feature: [Windows Compatibility] Add PowerShell Script as an Alternative to Grep on Linux Aug 12, 2024
@kthatipally kthatipally changed the title Non-breaking feature: [Windows Compatibility] Add PowerShell Script as an Alternative to Grep on Linux (:sparkles:) [Windows Compatibility] Add PowerShell Script as an Alternative to Grep on Linux Aug 12, 2024
@kthatipally kthatipally changed the title (:sparkles:) [Windows Compatibility] Add PowerShell Script as an Alternative to Grep on Linux :sparkles: [Windows Compatibility] Add PowerShell Script as an Alternative to Grep on Linux Aug 12, 2024
@kthatipally kthatipally changed the title :sparkles: [Windows Compatibility] Add PowerShell Script as an Alternative to Grep on Linux ✨ [Windows Compatibility] Add PowerShell Script as an Alternative to Grep on Linux Aug 12, 2024
@kthatipally kthatipally changed the title ✨ [Windows Compatibility] Add PowerShell Script as an Alternative to Grep on Linux ✨ Windows Compatibility-Add PowerShell Script as an Alternative to Grep on Linux Aug 12, 2024
Copy link
Contributor

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good assuming the power shell code works.

Another option if you were interested in doing, is to create a new "grep_windows.go" and "grep_nix.go" that will compile grep_nix using build tags when on a nix system and windows when on windows.

This is a decent resource to see what I mean: https://dave.cheney.net/2013/10/12/how-to-use-conditional-compilation-with-the-go-build-tool

I think that we can do this as a follow up though if we want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants