✨ Get deps fallback for .war/.ear files if no jars found #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eemcmullan
changed the title
eemcmullan
changed the title
|
The only problem here is the case when there are multiple poms inside the WAR file, which is something that can happen. In that case, this solution would give a partial list of dependencies, since we are stopping after finding the first pom. Ideally we would find all poms and concat their respective deps |
|
@jmle What happens in cases where the POMs have a parent - child relation? Does the fallback parser care if it cannot fully resolve the parent or children modules? |
|
@jmle updated to get all poms |
Signed-off-by: Emily McMullan <[email protected]>
eemcmullan
force-pushed
the
deps-fallback
branch
from
07ddfda
to
d8e1d0a
Compare
pranavgaikwad
approved these changes
Oct 11, 2024
Signed-off-by: Emily McMullan <[email protected]>
eemcmullan
force-pushed
the
deps-fallback
branch
from
d8e1d0a
to
3a6032c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.