✨ Support for Amazon Load Balancer Ingress controller (#197) #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes konveyor#184 Fixes konveyor#167 (confirmed working with `feature_auth_required: true`) Relates to konveyor#170 These changes allow us to deploy Konveyor onto an Amazon EKS cluster that uses the Amazon recommended Amazon Load Balancer ingress opposed to 'nginx'. I deployed the EKS cluster for testing using this newly developed automation: https://github.com/konveyor/hack_env_helpers/tree/main/aws/eks I captured notes while exploring ALB Ingress here for debugging purposes: https://gist.github.com/jwmatthews/d492a4944c83dc3f2d016187d53d13b2 --------- Signed-off-by: John Matthews <[email protected]> (cherry picked from commit 00792cd)
djzager
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #184
Fixes #167 (confirmed working with
feature_auth_required: true) Relates to #170These changes allow us to deploy Konveyor onto an Amazon EKS cluster that uses the Amazon recommended Amazon Load Balancer ingress opposed to 'nginx'.
I deployed the EKS cluster for testing using this newly developed automation:
https://github.com/konveyor/hack_env_helpers/tree/main/aws/eks
I captured notes while exploring ALB Ingress here for debugging purposes:
https://gist.github.com/jwmatthews/d492a4944c83dc3f2d016187d53d13b2
Signed-off-by: John Matthews [email protected]
(cherry picked from commit 00792cd)