✨ Add ServiceMonitor for hub metrics #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Lucidi <[email protected]>
mansam
added a commit
to mansam/tackle2-operator
that referenced
this pull request
Jun 8, 2023
* Adds a ServiceMonitor to allow the in-cluster monitoring to scrape Hub metrics (requires an OpenShift cluster) * Adds a NetworkPolicy to expose the Hub's metrics port. * Adds RBAC roles to allow the operator to manage ServiceMonitors I'm not sure if there's a better way to test if the monitoring operator is available, or if there's a way to more tightly restrict the network policy. Related to https://issues.redhat.com/projects/MTA/issues/MTA-402 Signed-off-by: Sam Lucidi <[email protected]>
mansam
added a commit
that referenced
this pull request
Jun 8, 2023
* Adds a ServiceMonitor to allow the in-cluster monitoring to scrape Hub metrics (requires an OpenShift cluster) * Adds a NetworkPolicy to expose the Hub's metrics port. * Adds RBAC roles to allow the operator to manage ServiceMonitors I'm not sure if there's a better way to test if the monitoring operator is available, or if there's a way to more tightly restrict the network policy. Related to https://issues.redhat.com/projects/MTA/issues/MTA-402 Signed-off-by: Sam Lucidi <[email protected]>
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if there's a better way to test if the monitoring operator is available, or if there's a way to more tightly restrict the network policy.
I'll need to backport this to release-0.2 once it is merged.
Related to https://issues.redhat.com/projects/MTA/issues/MTA-402