🐛 Addon memory request and limit match. #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Ortel <[email protected]>
djzager
approved these changes
Nov 16, 2023
|
LGTM This probably leaves a lot less room for multiple pods to be scheduled at 2Gi, bursting to ~4Gi and running a node out of memory. This also makes the pods |
jmontleon
approved these changes
Nov 16, 2023
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploying the pod with request = limit should be a good (incremental) step towards preventing OOM kills.
My memory profiling suggests that 4Gi is a good number for our TestApp. Although, I can run analysis on the TestApp using 2Gi/2Gi just fine (though memory peaks at 1.9Gi) on my minikube but Pranav reports that he cannot.
We should still follow up with passing -Xmx=80% of limit to the Java provider.
IMHO, 4Gi is much higher than I would have expected for the analyzer. This means that when running on most personal, single node clusters (like minikube), we will only be able to analyze a few applications in parallel.