🌱 Use konveyor/ci in release workflow #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
djzager
commented
Nov 20, 2023
djzager
commented
- Also add new targets to Makefile for installing openshift-client and yq
- Refactor our method for preparing manifests for publish
fabianvf
reviewed
Nov 20, 2023
| description: "comma separated channel(s) this operator should be available on" | ||
| required: false | ||
| default: "" | ||
| # use_image_digest: |
There was a problem hiding this comment.
are we leaving this in for a reason?
There was a problem hiding this comment.
For some strange reason when I use the operator-sdk generate bundle ... --use-image-digests on our project it doubles up the relatedImages where each image is repeated multiple times. I tried to recreate the issue on memcached-operator and couldn't. Not certain it's worth the time.
Dropping for now.
| publish: | ||
| name: Build and Push Manifest | ||
| needs: release-components |
There was a problem hiding this comment.
do we want this one to depend on tests or something?
* Also add new targets to Makefile for installing openshift-client and yq * Refactor our method for preparing manifests for publish Signed-off-by: David Zager <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.