-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Update CRDs to v1alpha2 #336
Conversation
@shawn-hurley can you help verify this is correct for adding a new CRD version? I'm a little iffy. According to https://docs.openshift.com/container-platform/4.15/operators/operator_sdk/osdk-generating-csvs.html We should And then I guess we just list the new version? |
- description: Tackle | ||
displayName: Tackle | ||
kind: Tackle | ||
name: tackles.tackle.konveyor.io | ||
version: v1alpha1 | ||
- description: Tackle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems if 'served' is true for a version then make bundle will generate an entry here. I tested this by changing served to false for tackles and we ended up with only v1alpha2 instead of both.
4e393fe
to
15a0665
Compare
Signed-off-by: Jason Montleon <[email protected]>
The tests are failling from:
This is fixed by: But tests will not pass until everything is merged because the bundle is still using image: @djzager fyi we have an issue where operator role changes don't get tested. We probably need to build the container image replace it when building the bundle for tests to properly account for changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.