Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add ALM Examples for new CRs #369

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

jmontleon
Copy link
Member

No description provided.

@jmontleon
Copy link
Member Author

jmontleon commented Jul 23, 2024

This PR is dependent on #368 and should be rebased once #368 is merged to fix tests.

@jmontleon
Copy link
Member Author

@jortel can you please have a quick look and make sure these examples aren't insane.

@jmontleon
Copy link
Member Author

@fbladilo heads up on this one too. In downstream won't take the ALM example templates into account and you need to manually update the CSV (or ignore this/me if the opposite is true.)

Copy link
Contributor

@jortel jortel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Jason Montleon <[email protected]>
@jmontleon jmontleon merged commit 9d41c5a into konveyor:main Jul 24, 2024
11 checks passed
@fbladilo
Copy link
Contributor

@jmontleon Thanks for heads up, yes we need to manually add these to downstream templates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants