Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyzer ruleset errors not reported correctly. #26

Closed
jortel opened this issue Jul 13, 2023 · 0 comments · Fixed by #25
Closed

Analyzer ruleset errors not reported correctly. #26

jortel opened this issue Jul 13, 2023 · 0 comments · Fixed by #25
Assignees
@jortel

Comments

@jortel
Copy link
Contributor

jortel commented Jul 13, 2023 •
edited
Loading

Analyzer ruleset errors not reported correctly.
Should be reported as Report.Errors and Report.Status == Failed.
Errors reported as map keyed by ruleid which needs to be propagated.

report:
    id: 25
    createuser: admin.noauth
    updateuser: admin.noauth
    createtime: 2023-07-14T12:40:44.131234629Z
    status: Failed
    errors:
        - severity: Error
          description: '[Analyzer] eap8/eap7.eap8-faces-00009: Malformed response from grep, cannot parse  with pattern {filepath}:{lineNumber}:{matchingText}'
    activity:
        - Fetching application.

Depends on: konveyor/tackle2-hub#441

closes: #26

Also, prevent downloading duplicate rulesets.

closes: #11
@jortel jortel self-assigned this Jul 13, 2023
@jortel jortel mentioned this issue Jul 16, 2023
Merged
jortel added a commit that referenced this issue Jul 16, 2023
@jortel
✨ Improved analyzer errors reporting. (#25)
eb5eea7 
Appends analyzer reported errors to the TaskReport.Errors.
Prevent downloading duplicate rulesets.
closes: #26

---------

Signed-off-by: Jeff Ortel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jortel jortel

Labels
None yet
Projects
Core
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Improved analyzer errors reporting. jortel/tackle2-addon-analyzer
1 participant
@jortel