Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken "assessments initiated" metric #510

Closed
mansam opened this issue Oct 9, 2023 · 0 comments · Fixed by #511
Closed

Fix broken "assessments initiated" metric #510

mansam opened this issue Oct 9, 2023 · 0 comments · Fixed by #511
Assignees
@mansam
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@mansam
Copy link
Collaborator

mansam commented Oct 9, 2023

The konveyor_assessments_initiated_total metric was previously based on the number of POSTs to the Pathfinder proxy endpoint. This no longer works as assessments are now implemented directly in the Hub. The metric needs to be updated to increment when a new Assessment object is created, but not when one is imported.
@mansam mansam self-assigned this Oct 9, 2023
@mansam mansam changed the title Update how "assessments initiated" metric is determined. Fix broken "assessments initiated" metric Oct 9, 2023
mansam added a commit to mansam/tackle2-hub that referenced this issue Oct 9, 2023
@mansam
Inc assessment counter when a new one is created
8c5caa4 
Fixes konveyor#510

Signed-off-by: Sam Lucidi <[email protected]>
@mansam mansam mentioned this issue Oct 9, 2023
Merged
mansam added a commit that referenced this issue Oct 10, 2023
@mansam
🐛 Increment assessment counter when a new one is created (#511)
8168a59 
Fixes #510

Signed-off-by: Sam Lucidi <[email protected]>
aufi pushed a commit to aufi/tackle2-hub that referenced this issue Oct 30, 2023
@mansam @aufi
🐛 Increment assessment counter when a new one is created (konveyor#511)
697b502 
Fixes konveyor#510

Signed-off-by: Sam Lucidi <[email protected]>
@mansam mansam added the kind/bug Categorizes issue or PR as related to a bug. label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mansam mansam

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
Planning
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Increment assessment counter when a new one is created mansam/tackle2-hub
1 participant
@mansam