✨ RawError, RawActivity simplified. #458
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the API for use cases for which the new RawError() and RawActivity() were meant to support.
Especially the RawActivity(). The main case here is to report multi-line activity. In this case the activity is reporting something followed by multiple lines. The first line is the-activity followed by multiple-lines of detail. This PR simplifies this more than the RawActivity() because it can be achieved in (1) addon.Activity() call.
For example:
Results in:
The Error and RawError is achieved by reversing which is the edge case. Errorf() is added (instead of RawError) which makes for a more intuitive API.