Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 PrepareForArchetype should use criteria and tags #508

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

mansam
Copy link
Collaborator

@mansam mansam commented Oct 6, 2023

Previously PrepareForArchetype was using only the membership criteria to autofill assessments, but the enhancement specifies that it should use the archetype tags as well as the criteria tags.

Fixes https://issues.redhat.com/browse/MTA-1396

Previously PrepareForArchetype was using only the membership
criteria to autofill assessments, but the enhancement specifies
that it should use the archetype tags as well as the criteria tags.

Fixes https://issues.redhat.com/browse/MTA-1396

Signed-off-by: Sam Lucidi <[email protected]>
@mansam mansam requested a review from jortel October 6, 2023 12:51
Copy link
Contributor

@jortel jortel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mansam mansam merged commit 47a3daa into konveyor:main Oct 6, 2023
10 of 11 checks passed
aufi pushed a commit to aufi/tackle2-hub that referenced this pull request Oct 30, 2023
Previously PrepareForArchetype was using only the membership criteria to
autofill assessments, but the enhancement specifies that it should use
the archetype tags as well as the criteria tags.

Fixes https://issues.redhat.com/browse/MTA-1396

Signed-off-by: Sam Lucidi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants