Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Add missing Targets to ui.target.order after seeding #536

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

mansam
Copy link
Collaborator

@mansam mansam commented Oct 19, 2023

This also adds some convenience methods to the Setting model to make reading and updating their values somewhat less tedious.

Fixes #505

@mansam mansam requested a review from jortel October 19, 2023 20:11
Copy link
Contributor

@jortel jortel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
The container/list seems handy.

Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mansam mansam merged commit 8389678 into konveyor:main Oct 26, 2023
11 checks passed
aufi pushed a commit to aufi/tackle2-hub that referenced this pull request Oct 30, 2023
This also adds some convenience methods to the `Setting` model to make
reading and updating their values somewhat less tedious.

Fixes konveyor#505

---------

Signed-off-by: Sam Lucidi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seeding Targets causes custom targets to be dropped from the UI display order
3 participants